Closed (fixed)
Project:
Views Slideshow
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Sep 2009 at 02:40 UTC
Updated:
29 Sep 2009 at 07:30 UTC
This bug is only triggered when using a timeout value of 0. When using a 0 value in combination with next or prev settings to the jquery cycle plugin this should normally make the slideshow become fully manual (requiring the user to click 'next' / 'prev' buttons). However, if you set this to 0 in views_slideshow, the slideshow actually just starts switching very rapidly. I believe this is due to the value in settings.timeout being a string, not an int. When I cast it to an int it seems to work as it should.
This is the code in question:
var settings = Drupal.settings.viewsSlideshowThumbnailHover[fullId];
settings.targetId = '#' + $(fullId + " :first").attr('id');
settings.opts = {
fx:settings.effect,
speed:settings.speed,
timeout:settings.timeout,
The attached patch fixes this by simply adding parseInt(settings.timeout).
| Comment | File | Size | Author |
|---|---|---|---|
| views_slideshow_timeout_int.patch | 961 bytes | hadsie |
Comments
Comment #1
redndahead commentedI can verify that this fixes the issue. I will commit as soon as I get a couple of other items committed.
Comment #2
redndahead commentedCommitted this. Thanks a lot!!