Posted by teezee on September 11, 2009 at 4:24pm
Jump to:
| Project: | Vocabulary Index |
| Version: | 5.x-2.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Xano |
| Status: | closed (fixed) |
Issue Summary
In the vocabindex module some of the theme function calls are invalid (vocabindex.view.inc, line 375):
<?php
return array('list_items' => $items, 'pager' => theme_pager());
?>Should be
<?php
return array('list_items' => $items, 'pager' => theme('pager', $pager));
?>And calls to theme_item_list() should be reworked (vocabindex.module, line 297):
<?php
$output .= theme_item_list($items, NULL, 'ul', array('id' => 'dynamic-help'));
?>Should be
<?php
$output .= theme('item_list', $items, NULL, 'ul', array('id' => 'dynamic-help'));
?>So far i've found theme_table, theme_image, theme_pager, theme_item_list calls that should be rewritten.
Maybe they should even be rewritten so that the caching mechanism is theme independent. Currently, if the cache is built up using theme A, the overwritten theme functions for theme B are not taken into consideration (but i'll pop that into a separate issue if you don't mind:).
To reproduce
- Copy the default theme_pager() code (http://api.drupal.org/api/function/theme_pager/6) and add it to Garlands template.php
- Rename the
function theme_pager(...tofunction garland_pager(... - Change something about the output of the pager so that your change will be easy to recognize
- Go to a vocabulary index page with more than 25 tags on it
- The change you've applied by overriding theme_pager() will not be visible.
Comments
#1
Good catch! The caching 'issue' is by design. Aggressive caching caches page content after it's been rendered. If you can't or don't want to use this, you can use normal caching.
#2
And it's fixed in the dev version :) Thanks for reporting this bug!
#3
This needs to be backported to DRUPAL-5--2.
#4
Fixed in Drupal-5--2 and some additional invalid theme calls in DRUPAL-6--2 have been fixed as well.
#5
#6
Automatically closed -- issue fixed for 2 weeks with no activity.