notifications 2.0 compatibility, or 4.x?

I'm not currently looking for a co-maintainer, but a patch for Notifications 2.1 compatibly would be welcome.

This task is partially complete; my sandbox at http://cvs.drupal.org/viewvc.py/drupal/contributions/sandbox/grendzy/not... contains partial support for 2.1.

shenzhuxi,
Your post in the CVS application queue contained a zip file – Please post a patch in the unified diff format. Instructions can be found here: http://drupal.org/patch/create

Thanks!

Thanks for posting the patch. The first priority is getting compatibility with Notifications 2.0; would it be possible to get a patch that just implements that? (The additional subscription types are interesting as well, but updating the API is a prerequisite.)

There are changes in the 2.x API, such as hook_notifications('names') is deprecated. The documentation you linked is a bit out of date.

Some of this has been accounted for in the new 2.x branch of notifications_location.

skyred via irc:
Notification 4.x supports custom subscription, maybe notifications location can be rewritten to take advantage of the custom subscription?

I see Notifications Location module will become more useful, since mobile development is heating up rapidly. It will be great if we can work towards notification 4.x.

Does this module work with Notification 4.x?

Regards,

Tobi

It doesn't work with current 4.x notifications. In all honesty I'm not likely to work on it soon, though I'll review any patches here.

Grendzy,
Can you tell me which version of Notifications that your module does work with? I'm thinking of backing up to that version of Notifications as the ability to notify a user when local content is created is very important to my site.

Thanks!

amwood: If you're looking to try an older version, I would get the DRUPAL-6--1 branch, and try with Notifications 6.x-1.1.

Grendzy - Thanks for the guidance! Backing up to Notifications 6.x-1.1 and Notifications Location 6.x-1.1 worked perfectly.