Hi

After giving myself access to the emailpage module, i can view the settings but after making changes and clicking on save configurations the changes aren't saved, although drupal comes back saying they have? Is it also possible to clear the counter as there is only a no radio button?

Also the web link doesn't work correctly for example http://www.mysite.net/site/test//site/test/ is displayed instead of http://www.mysite.net/site/test.

Any ideas?

This is already filed as an issue, was just wondering if any one had similar problems?

Comments

alliax’s picture

Yes of course since it is an issue I had the problem myself, and here the issue that helped me correct it :
http://drupal.org/node/43437

alliax’s picture

for the other point (bad url) I didn't check yet. Because I saw an address with double // but since it worked fine, I didn't give a second thought. Maybe I should!!

sepeck’s picture

Trailing / in the URL generally means you have an extra / somewhere. Either at the end of your base_url or in the admin >> settings you have '/files' instead of 'files'.

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

alliax’s picture

I mean it happens only with the emailthispage module. So that would perhaps be in the module itself that there is an extra / ?

sweetcorn’s picture

Hi Alliax

Thanks for the link, that sorted the problem of not being able to save the chages.

Have you noticed the other problem about the bad urls it produces?

somes’s picture

alliax looks like your right there seems to be extra '/' being introduced on line 82 and 84 are they essential

alliax’s picture

In those 2 lines I removed this . '/'

and it works fine now.

Maybe this has to do with the base href thing that changed in drupal 4.7 I don't know but it works fine by removing those characters, although even with two / the browser (or the web server) could work out the URL fine. SO it was not a critical bug.

sepeck’s picture

File an issue against the emailthis page module project so the maintainer knows.

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

alliax’s picture

It's already an issue I believe, but I'll go andadd something about this thread.

skyl1ne’s picture

My lines 82-84 look like this:

Line 82 setcookie('referer', $nodelink, time()+300, '/', '.'.$host['host']);
Line 83 } else {
Line 84 $nodelink = $base_url;

Can you tell me what to remove to avoid the // http://www.mysite.net/site/test//site/test/ URL problem?

Thank you.

somes’s picture

No your code line should look after changes as

$nodelink = url('node/'. $_GET['nid'] ."#comment-". $_GET['cid']);
} else {
$nodelink = url('node/' .$_GET['nid']);

Just a note these changes still wont work it you have drupal installed in a sub folder, as you will get duplication in the url it should be fine if drupal is install in the root directory.