Closed (fixed)
Project:
Read More Link (Drupal 6 and earlier)
Version:
6.x-5.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Sep 2009 at 15:36 UTC
Updated:
29 Sep 2009 at 19:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
aaron commentedforgot to set status
Comment #2
aaron commentedthat should really be check_plained so we don't end up with a security alert... :P
new patch attached.
Comment #3
aaron commentedHere, this one is even better: it takes the
and moves it into the variable, and puts the whole thing in the theme layer, where it belongs. Also using filter_xss rather than check_plain, so we can see the HTML for the hard space properly (in addition to anything else an admin might want to stick in there, such as…(…). In fact, this uses that for the ellipsis anyway (the character for three dots…, rather than three periods..., which can sometimes be better for typesetting). This allows editors to change that to...(...),. . . (. . . ),& #x2026;(…),& #8230;(…), an image, or whatever their needs require.Comment #4
aaron commenteda patch would be nice, of course...
Comment #5
todd nienkerk commentedaaron: This is awesome. Thanks!
Let's change the notion of "ellipsis" to a more generic "separator." The default should be a single, non-breaking space. Can this be done without double-encoding these characters on output?
Comment #6
aaron commenteddone. and are the characters being double-encoded for you? they shouldn't be, as I'm using a straight filter_xss.
Comment #7
aaron commentedchanged all variables to $separator, removing all last vestiges of $ellipse.
Comment #8
todd nienkerk commentedThis has been committed and will be released as 6.x-5.0-RC2. Thanks!