Posted by aaron on September 14, 2009 at 3:36pm
| Project: | Read More Link (Drupal 6 and earlier) |
| Version: | 6.x-5.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This patch adds configurable ellipsis marks (...) between the teaser and the 'Read More' link.
| Attachment | Size |
|---|---|
| ed_readmore-ellipsis.patch | 1.58 KB |
Comments
#1
forgot to set status
#2
that should really be check_plained so we don't end up with a security alert... :P
new patch attached.
#3
Here, this one is even better: it takes the
and moves it into the variable, and puts the whole thing in the theme layer, where it belongs. Also using filter_xss rather than check_plain, so we can see the HTML for the hard space properly (in addition to anything else an admin might want to stick in there, such as…(…). In fact, this uses that for the ellipsis anyway (the character for three dots…, rather than three periods..., which can sometimes be better for typesetting). This allows editors to change that to...(...),. . . (. . . ),& #x2026;(…),& #8230;(…), an image, or whatever their needs require.#4
a patch would be nice, of course...
#5
aaron: This is awesome. Thanks!
Let's change the notion of "ellipsis" to a more generic "separator." The default should be a single, non-breaking space. Can this be done without double-encoding these characters on output?
#6
done. and are the characters being double-encoded for you? they shouldn't be, as I'm using a straight filter_xss.
#7
changed all variables to $separator, removing all last vestiges of $ellipse.
#8
This has been committed and will be released as 6.x-5.0-RC2. Thanks!
#9
Automatically closed -- issue fixed for 2 weeks with no activity.