More link to point to custom URL - Arguments enhanced

This approach will probably make some of you laugh, but what I the following:

Applied patch http://drupal.org/node/564106#comment-2014578 to make a "Custom URL:"-field appear.

From here my goal was to "mirror" the way filter format options appear in the "Header", "Footer" or "Empty text" options in views (all these options have textareas where users can input Filtered HTML, Full HTML or PHP Code).

Following pieces of code I added to the patched file "plugins/views_plugin_display.inc":

Change line 169:

- 'use_more' => array('use_more', 'use_more_text', 'more_url'),
+ 'use_more' => array('use_more', 'use_more_text', 'more_url', 'more_url_format'),

Add after line 243 ("'use_more_text' => TRUE,"):

+ 'more_url' => TRUE,
+ 'more_url_format' => TRUE,

Add after line 346 ("),"):

+ 'more_url_format' => array(
+    'default' => FILTER_FORMAT_DEFAULT,
+ ),

Add after line 916 ("),"):

+
+ $form['more_url_format'] = filter_form($this->get_option('more_url_format'), NULL, array('more_url_format'));

I've added the already edited file "views_plugin_display.inc" (remember - after "views-more-url_0.patch") and a screenshot of the what it's achieved by it. This looks ok so far... but...

... The problem is - and that is why I started the post with "make some of you laugh" - that if you write php code in the "Custom URL"-field this filter choice isn't saved and therefore the value in the field is probably taken as "Filtered HTML" - so in other words nothing really happens. With my current knowledge I cannot see where to make this "Custom URL"-field accept the filter settings. The two are simply not connected... And security issues are not even taken into account at that stage...

But this could be a start or something. Hope someone can provide a better approach.

Thanks

I would - I was about to do it, but I cannot figure out the meaning of the value after the comma in the patch... :(

E.g. "@@ -166,7 +166,7 @@ class views_plugin_display extends views_plugin {" in

       'use_ajax' => array('use_ajax'),
       'items_per_page' => array('items_per_page', 'offset', 'use_pager', 'pager_element'),
       'use_pager' => array('items_per_page', 'offset', 'use_pager', 'pager_element'),
-      'use_more' => array('use_more', 'use_more_text'),
+      'use_more' => array('use_more', 'use_more_text', 'more_url'),
       'link_display' => array('link_display'),
       'distinct' => array('distinct'),
       'exposed_block' => array('exposed_block'),

or "@@ -341,6 +341,9 @@ class views_plugin_display extends views_plugin {" in

         'default' => 'more',
         'translatable' => TRUE,
       ),
+      'more_url' => array(
+        'default' => '',
+      ),
       'link_display' => array(
         'default' => '',
       ),

Can you give me a short hint pls. I would really appreciate it! Thanks!

Update: I'll try to figure it out of course, you gave me a link, didn't see it, sorry.

Here is the patch! :)

Please apply it in the views/plugins directory.

Don't forget: it must be applied after http://drupal.org/files/issues/views-more-url_0.patch has been applied.

Sorry,

here is the patch applying from the views root directory.

I've added a line to the patch inside the function options_submit. That way the value given to the filter section of more_url is being submitted and "remembered".

"The problem" described in #2 still persists though (URL is being shown the same, no matter in "Filtered HTML" or "PHP Code"-format. I think the value in the textarea is not been rendered to go through the filter...

There is some code after line 1662 in views_plugin_display.inc that handle those tasks, but I cannot look through it...

 /**
   * Not all display plugins will support filtering
   */
  function render_filters() { }

  /**
   * Render the 'more' link
   */
  function render_more_link() {
    if ($this->use_more() && $this->view->total_rows > $this->view->pager['items_per_page']) {
      $path = $this->get_path();
      $path = $path ? $path : $this->get_option('more_url');
      if ($path) {
        $path = $this->view->get_url(NULL, $path);
        $url_options = array();
        if (!empty($this->view->exposed_raw_input)) {
          $url_options['query'] = $this->view->exposed_raw_input;
        }
        $theme = views_theme_functions('views_more', $this->view, $this->display);
        if ($this->get_option('more_url')) {
          $path = $this->get_option('more_url');
        }
        $path = check_url(url($path, $url_options));
        return theme($theme, $path, $this->use_more_text());
      }
    }
  }

  /**
   * Render a text area, using the proper format.
   */
  function render_textarea($area) {
    static $formats = array();
  /**
   * ...
   * More code follows in views_plugin_display.inc...
   */

Any ideas?

I think this issue here is the one that should be taken into account, as the other one ("More link to point to custom URL") has already been solved (you already have the possibility to add static URL-addresses to your "more" links in views).

I think issue http://drupal.org/node/564106 ca be marked as fixed and development of an arguments solution of views-more-links should go on here?

@dereine

I'm passing my views to a "My profile" page which is handled by panels. There is a section, e.g. my friends and the more link of the view should look like "mysite/%/friends".

Now I know this can be overriden in panels:
- panels has a "Provide a "more" link that links to the view"-function - but you aren't able to change the "more"-text there.
- panels has also "Override URL:" function, where arguments from the URL are pluggable, which is what I want to achieve by views, through that php filter.

Why would I need that:
- to change the "more"-text to something like "See this user's friends" or even better "See Johnny's friends" (suppose the user is called Johnny).
- the "more"-link should provide a dynamic address to that user's friends, whose profile is being shown. I want to use the http://drupal.org/project/quicktabs module with views to save space on the profile page. In there every tab shows a separate view and that is where you cannot use panels "Override URL:"-function anymore as this single pane contains several views through Quicktabs and of course you wouldn't set the same URL for different "more"-links within that Quicktabs.
- you would have that problem anyway if you don't use panels and you need the "more"-link to show to a specific location, depending on what user or node you are viewing at the moment...

So it would be possible to get the User ID or Node ID being watched and put it into the Custom URL in views through php. This is very similiar functionality to what the header, footer or empty text fields in views offer.