Refactor _json to use the cache rather to reconstruct the whole form on every ajax request.

EugenMayer - September 16, 2009 - 11:42
Project:Hierarchical Select
Version:6.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:postponed
Description

Well reasons should be more then clear, this costs a lot of performance, rebuild the form, call all alter methods and stuff on every ajax call.

And all this to get one element of those thousands. Fixing this will impact HS performace a lot, i guess.

Fileframework/attach module shows how it should be done. It does exactly the same, even with file uploads, but actually not rebuilding the whole form

#1

EugenMayer - September 16, 2009 - 11:50

most likely we should simply use ctools_rebuild_form from ctools

#2

Wim Leers - September 21, 2009 - 11:58
Status:active» postponed

Agreed that the performance in this part of HS should be improved a lot. Postponed for the next major version though, for the obvious reason that this is a major change. I'd welcome a patch :) Basing it on ctools_rebuild_form is fine by me.

 
 

Drupal is a registered trademark of Dries Buytaert.