'Read more' link is always displayed

yes this was a frustrating thing about flexinode, thanks

This is not the correct way, sorry. This will introduce fuzzyness. the readmore will often appear when it should not and often not, when it should. Then having it always show up is a better solution.

There are two situations in which the Read More link should be displayed:
1) There are fields where (teaser content != body content)
2) There are fields that are not displayed in the teaser

The attached patch implements this logic.

Unless I'm missing something, this should work 100% of the time ;-)

Your logic seems strange:

 if (!empty($body_data) && $body_data) {
 }
 else {
   $node->readmore = TRUE;
 }

You are saying: if there is no $body_data AND body_data is empty, set the readmore TRUE....

please explain this, in detail. I fear I missed something. Else set status to "code needs work".

Thanks for reviewing.

I think the patch got misapplied somehow in what you are looking at. The else in your snippet goes with the if ($field->show_teaser).

This is the resulting code, but massaged a bit for readability:

        if (!empty($body_data) && $body_data) {
          $node->body .= theme('flexinode_'. $field->field_type, $field->field_id, $field->label, $node->$fieldname, $teaser ? $teaser_data : $body_data);

          if ($field->show_teaser) {

            if ($body_data != $teaser_data) $node->readmore = TRUE;

            $node->teaser .= theme('flexinode_'. $field->field_type, $field->field_id, $field->label, $node->$fieldname, $teaser_data);

          }
          else $node->readmore = TRUE;

        }

The outer if just checks for valid content. If there is content, it is appended to the node's body.

Then we look at whether the field is to be displayed in the teaser.

If it is, and the body contains more (i.e. different) stuff than the teaser itself, we want to set READMORE.

If it isn't, then we know we want to set READMORE.

Does this help?

Note, alignment got messed up in first if above.

This is the actual resulting code that should be produced by the patch:

        if (!empty($body_data) && $body_data) {
          $node->body .= theme('flexinode_'. $field->field_type, $field->field_id, $field->label, $node->$fieldname, $teaser ? $teaser_data : $body_data);
          if ($field->show_teaser) {
            if ($body_data != $teaser_data) {
              $node->readmore = TRUE;
            }
            $node->teaser .= theme('flexinode_'. $field->field_type, $field->field_id, $field->label, $node->$fieldname, $teaser_data);
          }
          else {
            $node->readmore = TRUE;
          }
        }

any chance of making this a real patch?

Is there something wrong with the one that's attached in #4?

http://drupal.org/node/58202#comment-92140

Rerolled patch against CVS.

fixed problem w/ generating body

Committed. thanks all!