Posted by joehudson on September 20, 2009 at 5:54pm
| Project: | Simplenews |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (duplicate) |
Issue Summary
Hi,
Last year I integrated some handy features into Simplenews including:
- full templating for subject, body and footer.
- tokens for subject, body and footer, allowing emails with "hi, !subscribername..."
- custom token callback functions, so you can dynamically generate customized content for particular subscribers. callbacks get the subscriber account object and return the text to be substituted
- customizable anti-spam policy notice for each subscription block (I'm suprised this still isn't a standard feature)
- optional name field in subscription block (enabled in the block config page), so subscribers can be associated with a name, even if they don't have a full user account
- made newsletters have assignable authors (not fully implemented, but currently serves to restrict access appropriately) The idea is you can have multiple users with their own newsletters, that can only author their own newsletters, not any newsletter (which seems to be the current behaviour).
- added the subscriber hash to the session, to enable other modules to pick up on the fact someone has recently subscribed
- altered the presentation of the subscription block so by default people are subscribed (no radio buttons) and the submit button is labled 'subscribe'. seems to make much more sense!
- fully configurable subject, so it doesn't have to always begin with '[newletter name]'
think that's most of it.
I've just finished patching the latest (10th Sept) dev release of Simplenews with these added features and wanted to share. As you will see from the code, I've made quite a lot of changes (including a few to the schema).
It would be great if some of these handy features could be rolled into the standard release! I'd love some feedback on this.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| simplenews.zip | 200.27 KB | Ignored: Check issue status. | None | None |
Comments
#1
:) left out something in the simplenews.module..
#2
haha, just remembered, some of the theming of the template callback interface uses a little module I wrote for theming lists in various ways. easy enough to strip out the dependency, but here it is for anyone who wants to use it.
#3
Nice functions, but when I enable show name in block config, there still does not appear any name field any hint?
#4
subscribing
#5
This sounds great, Joe - thanks! New features are already being implemented in the 6.x-2.x-dev snapshots (including token support), so I guess it would be best if you could sync your improvements with the 2.x code base.
#6
subscribe
#7
subscribe
#8
I hope they wil be into standard release too, you are magic!
#9
I'll respond in detail:
* full templating for subject, body and footer.
> Body and footer have a template. Subject won't get one (see the last point).
* tokens for subject, body and footer, allowing emails with "hi, !subscribername..."
> There will only be a solution if it is flexible. But it is a biggy!
* custom token callback functions, so you can dynamically generate customized content for particular subscribers. callbacks get the subscriber account object and return the text to be substituted
> This is not something Simplenews will solve. It needs a specialized module like
* customizable anti-spam policy notice for each subscription block (I'm suprised this still isn't a standard feature)
> You are the first asking for it. Write your own module with a hook_form_
* optional name field in subscription block (enabled in the block config page), so subscribers can be associated with a name, even if they don't have a full user account
> See above, the 'hi, !subscribername' issue.
* made newsletters have assignable authors (not fully implemented, but currently serves to restrict access appropriately) The idea is you can have multiple users with their own newsletters, that can only author their own newsletters, not any newsletter (which seems to be the current behaviour).
> There is a request for OG support. I believe this is similar.
* added the subscriber hash to the session, to enable other modules to pick up on the fact someone has recently subscribed
> The using the session is not the way to do it. Use a hook or use the actions/trigger system.
* altered the presentation of the subscription block so by default people are subscribed (no radio buttons) and the submit button is labled 'subscribe'. seems to make much more sense!
> There is an issue in the queue to improve the subscription block.
* fully configurable subject, so it doesn't have to always begin with '[newletter name]'
> I like to see this included in 2.x. In the admin pages a text field for subject with token replacement.
joehudson, I like to see your patch comming for a newsletter subject with token replacement.
#10
All remaining issues of this thread have an individual issue in this queue. Marking duplicate.
#11
joehudson, can you please post a patch against the 6.x-2.x-dev version of Simplenews, that only covers the
optional name field in subscription block, so subscribers can be associated with a name, even if they don't have a full user account
feature? Thanks.
#12
ooohh yes I would LOVE to see a patch that would only do that.
have been following quite a few issues on this, and although i completely understand the requirements on flexibility and configurability for the official releases, I would really really love to see a patch that could just add a name-field to the form (and the db-table...)
joehudson, do you think this would be an option for you? if not, let us know, I'm willing to dive into your code and try to come up with a patch myself. just don't want to reinvent the wheel..