Download & Extend
User Comment » Issues

Allow site builders to choose their own defaults.

Posted by himagarwal on September 21, 2009 at 5:41pm
Project:User Comment
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

1. By default "Skip [note-type] approvals" is tick. Is it possible to make it untick by default.
2. By default a settings box appears at /user/[user-id] where a user can tick/untick approvals, email notifications etc. Is it possible to completely disable this setting box for non-admin users.
3. How non-admin user can approve/disapprove without email notification.
4. Suggestion: It would be nice, if settings are provided in each node-type (e.g.: at admin/content/node-type/[node-name]

Please reply! :-)

Login or register to post comments

Comments

#1

Posted by rschwab on December 6, 2010 at 1:05am

#1 I think is a won't fix. It would effectively disable commenting until the author became aware of the feature.

#2 Is another won't fix. If you don't have approval permissions, the form isn't there. But if you do have approval permissions its essential to let the user disable e-mails getting sent to them. A site builder can turn this off with a theme function if they really want to do that.

#3 is a good point. I've opened #989962: Add option for approval notifications on login to deal with that specifically. Thanks for pointing it out!

#4 Not sure what you mean here. Can you explain further?

#2

Posted by rschwab on December 14, 2010 at 9:02am
Category:support request» feature request
Status:active» closed (duplicate)

Ok I'm guessing you mean some kind of per content-type setting like content access module has?

See the image at: http://drupal.org/node/257453

Assuming that's the case, I'm going to add it to a very similar issue at #723080: Allow per content type admin my comments and close this one as a duplicate. Please re-open if you want to provide more input.

#3

Posted by SchwebDesign on March 14, 2011 at 7:13pm

please see related post also at: http://drupal.org/node/1064964#comment-4208502

Okay i just found Untick "Skip page approvals" by default: http://drupal.org/node/583698 and your response:

#1 I think is a won't fix. It would effectively disable commenting until the author became aware of the feature.

am i misunderstanding this?

In my case, having this ticked disabled emails being delivered when comments were made which makes sense... however if a user doesn't know this is checked by default, they'll never know why they're not receiving emails notifications. When unticked, i got the email notification as expected. Either way, this checkbox had NO effect on allowing/disallowing commenting. Rather, it did have effect on whether or not email notifications were received, and as such, seems it should be DISABLED by default as people expect email notifications to be received with this module "out of the box" unless that's turned off by unchecking "Receive e-mail notifications"

...any thoughts...?

thanks!

#4

Posted by SchwebDesign on March 14, 2011 at 7:22pm

For anyone else who's interested, i "hacked" this by changing line 243 of usercomment.module from

              '#default_value' => isset($edit['usercomment_approve_'. $node->type]) ? $edit['usercomment_approve_'. $node->type] : 1,

to
              '#default_value' => isset($edit['usercomment_approve_'. $node->type]) ? $edit['usercomment_approve_'. $node->type] : 0,

seems to have worked for now.

#5

Posted by rschwab on March 14, 2011 at 8:18pm
Title:Untick "Skip page approvals" by default.» Allow site builders to choose their own defaults.
Version:6.x-1.0-beta1» 6.x-2.x-dev
Component:User interface» Code
Status:closed (duplicate)» active

Instead of being mean and not letting you do this, I'm going to work on adding these options to the admin settings form. Stay tuned.

#6

Posted by SchwebDesign on March 14, 2011 at 8:19pm

thanks!

#8

Posted by rschwab on April 5, 2011 at 7:22am
Status:active» fixed

Pushing to 2.x-dev. Patch as described here http://drupal.org/node/1064964#comment-4208814

AttachmentSize
583698-defaults.patch 2.95 KB

#9

Posted by System Message on April 19, 2011 at 7:31am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here