Hello,

thanks for the great module!

In my view all displays have a header with some links inside. The header of the first display is shown about the display-tabs. The header of the other displays are never shown.

I my opinion all header must be shown under the tabs.

Is there any solution for this?

Thanks
dendie

CommentFileSizeAuthor
#8 viewsdisplaytabs-do_not_overwrite_header-585574-8.patch4.76 KBacrollet
#7 viewsdisplaytabs-do_not_overwrite_header-585574-7.patch725 bytesacrollet

Comments

braindrift’s picture

braindrift commented

Correction:

all header will be shown, it was my fault, that the header of the second tab was not shown. But the issue that the header is shown about the tabs is stil there.

Thanks

braindrift’s picture

braindrift commented
Title: Views header about the tabs and not all headers are shown » Views header about the tabs

changing of the issue title

braindrift’s picture

braindrift commented
Status: Active » Needs review

Possible solution:

I'm sorry, that it is not a patch. can't create a patch now. Maybe someone else

function viewsdisplaytabs_preprocess_views_view(&$vars) { //    Line 64
.
.
.
//after line 94
    // Build header
    $header = theme('viewsdisplaytabs_tab_groups', $displays, 'viewsdisplaytabs-tab-group');
    $header .= $vars['header'];
    
    // Assign header
    $vars['header'] = $header;
.
.
.

a review would be great.

Thanks

solipsist’s picture

solipsist commented
Category: bug » feature
Priority: Critical » Normal
Status: Needs review » Postponed

In effect: You'd like a setting to prepend or append the tabs to the view's header. Sure, can be done. I'll add it to the TODO list.

braindrift’s picture

braindrift commented
Title: Views header about the tabs » Views header above the tabs
Blackwolf’s picture

Blackwolf commented

Subscribe.

acrollet’s picture

acrollet commented
Version: 6.x-1.0-beta4 » 6.x-1.x-dev
StatusFileSize
new viewsdisplaytabs-do_not_overwrite_header-585574-7.patch725 bytes

for reference, the code above as a patch.

acrollet’s picture

acrollet commented
Status: Postponed » Needs review
StatusFileSize
new viewsdisplaytabs-do_not_overwrite_header-585574-8.patch4.76 KB

Here is a patch (against the 7.x version) that adds a setting selection to overwrite, prepend or append to the view header.

mediaformat’s picture

mediaformat commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I haven't tested 6.x version, but the 7.x version works!