The last chat messages in the chat 'window'/area are getting reloaded in an infinite loop again and again and again, in some important browsers (at least faulty in Safari 4 and FF 3 - Opera 9 seems fine though, didn't test in IE).
In other words: If some chatter posts a chat message, she and all other participants are receiving the same message time and again, i.e. the same last message get's appended in the chat area infinite times.
Since this happens with both branches in in several browsers, and renders the module basically useless, i marked it critical.
Since we're in a *very* time-tight project, we'd need some hint here real soon!
If there's just a bug, we're happy to help fixing it!
Is there an older version which is not subject to this bug?
Thanks!!

Comments

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »

will look into this. i'm picking up the module after quite a break, and it was very broken.

patches welcome.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Postponed (maintainer needs more info)

i can't reproduce this. can you give me some more information about exactly how you reproduced this?

i tested this on the latest DRUPAL-6--1 branch. please set back to active when you post some more information.

danielnolde’s picture

danielnolde commented

Hey Justin,

just double checked on two different systen (local VMWare Ubuntu server, differently set up dedicated Dev Server Ubuntu) and three different browsers, the problem is definitely there as described and persists.

Exemplary system data:

Drupal: 6.14, Acquia Drupal
MySQL: 5.0.51a
PHP: 5.2.4-2ubuntu5.6
Apache/2.2.8 (Ubuntu) PHP/5.2.4-2ubuntu5.6 with Suhosin-Patch

Chat Room: 6.x-1.0-beta - as well as 6.x-1.x-dev (2009-09-29)

we can try and help with the bugfix - but we need a hint in which code/function/client-server-side/file to start looking... any ideas?

cheers,

daniel

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-1.x-dev » 6.x-1.0-beta9

please test again with 6.x-1.0-beta9. can you describe this in more detail? perhaps set up an install somewhere i can open in a browser and see the problem? i still can't reproduce this issue.

as for hints, i still can't reproduce this issue. one possibility is that this code

/**
 * Latest message ID.
 *
 * Updates <input type="hidden" id="edit-last-cmid" value="..."/> from
 * <div id="response-last-cmid">...</a>. This is sent with each AHAH request so
 * messages are not fetched more than once.
 */
Drupal.behaviors.chatroomLastCmid = function(context) {
  retval = $('#response-last-cmid', context).each(function() {
    $('#edit-last-cmid').val($(this).html());
  }).remove();
  return true;
};

isn't working as it should, and the last seen cmid is not being updated? can you start logging the POST'ed cmid value to a file and check that its ok?

there is an underlying issue with the initial 6.x port in that cmid is not validated on the client side at all, so requests can pass each other on the wire, and the same messages get written twice in a given client.

i've fixed that in the 6.x-2 branch, but you're issue sounds bigger than that.

Anonymous’s picture

Anonymous (not verified) commented

ping? still seeing this? have you tried the 6.x-2 code?

going to close this without feedback shortly.

Anonymous’s picture

Anonymous (not verified) commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.