Closed (fixed)
Project:
Plugin Manager
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2009 at 09:03 UTC
Updated:
19 Jun 2010 at 03:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedI'm curious how this would work since you cannot activate a module with missing dependencies.
Comment #2
WildBill commentedGood point. I guess it would only be checking the dependencies for non-activated modules.
Comment #3
akalsey commentedSince you can't activate modules without including their dependencies, perhaps this check shouldn't result in an error message. Error messages are sort of scary and imply that something needs fixing. In this case, unless you actually wanted to enable a module that was missing the dependency, nothing needs to be fixed. A notice would probably be sufficient. It might also be nice to add a note to the Status page using hook_requirements
Attached is a patch that makes these changes, as well as rewording the message to be less ominous.
Comment #4
jaypanI would love it if there was an option to turn off these notifications. If I am missing a dependency, I will find out soon enough when I go to install the module that depends on another. I don't like it when I go to a bunch of pages and get this error.
I absolutely love the module though - it's one of three modules I include in my installation package I have put together for every single site I build. I just don't like this one feature of it.
Comment #5
Anonymous (not verified) commentedIn the (hopefully) upcoming release of 6.x-2.x, this "feature" will be removed. ;)
Comment #6
Anonymous (not verified) commentedComment #7
Karlheinz commentedFor those who want to disable this altogether:
The function that does this is called
plugin_manager_missing_dependencies(). It is itself called in two other functions,plugin_manager_form_system_modules_alter()andplugin_manager_form_system_themes_alter().So, to disable dependencies checking, open up
plugin_manager.moduleand comment out lines 192-195:...and lines 207-211:
I did this, with no ill effects thus far.
Comment #8
Anonymous (not verified) commentedRemoved in 6.x-1.x dev.
Comment #9
Anonymous (not verified) commentedAll dependency checking has been removed as it is outside of the scope of this module's purpose.
Comment #10
jaypanGlad to hear that! Will you be rolling out a new version soon?
Comment #11
Anonymous (not verified) commentedIt will probably be several weeks. I'm focusing all of my effort (after my day job) into getting 6.x-2.x ready to release. It still has a way to go, but I think I'm close to preparing an alpha.
Comment #12
jaypanGood luck!