The new feature which checks for missing module dependencies is very cool. My only objection is that it checks for missing dependencies (and gives me the warning message) for modules which are not actually activated. Many of the "bigger" modules come with a big set of sub-modules which have their own dependencies, many of which I never intend to use. The Plugin Manager module is warning me about missing dependencies for modules that I don't care about. In my mind, the warning should only appear for activated modules (same behavior as Update module).

CommentFileSizeAuthor
#3 plugin_manager_589172.patch1.55 KBakalsey

Comments

Anonymous’s picture

I'm curious how this would work since you cannot activate a module with missing dependencies.

WildBill’s picture

Good point. I guess it would only be checking the dependencies for non-activated modules.

akalsey’s picture

Status: Active » Needs review
StatusFileSize
new1.55 KB

Since you can't activate modules without including their dependencies, perhaps this check shouldn't result in an error message. Error messages are sort of scary and imply that something needs fixing. In this case, unless you actually wanted to enable a module that was missing the dependency, nothing needs to be fixed. A notice would probably be sufficient. It might also be nice to add a note to the Status page using hook_requirements

Attached is a patch that makes these changes, as well as rewording the message to be less ominous.

jaypan’s picture

I would love it if there was an option to turn off these notifications. If I am missing a dependency, I will find out soon enough when I go to install the module that depends on another. I don't like it when I go to a bunch of pages and get this error.

I absolutely love the module though - it's one of three modules I include in my installation package I have put together for every single site I build. I just don't like this one feature of it.

Anonymous’s picture

In the (hopefully) upcoming release of 6.x-2.x, this "feature" will be removed. ;)

Anonymous’s picture

Version: 6.x-1.10 » 6.x-2.x-dev
Karlheinz’s picture

For those who want to disable this altogether:

The function that does this is called plugin_manager_missing_dependencies(). It is itself called in two other functions, plugin_manager_form_system_modules_alter() and plugin_manager_form_system_themes_alter().

So, to disable dependencies checking, open up plugin_manager.module and comment out lines 192-195:

$missing = plugin_manager_missing_dependencies();
if ($missing['#alert']){
    drupal_set_message(t("You have missing dependencies! ").l(t("Go here"),"admin/plugin_manager/deps").t(" to resolve them."),"error");
  }

...and lines 207-211:

$missing = plugin_manager_missing_dependencies();
if ($missing['#alert']){
    drupal_set_message(t("You have missing dependencies! ").l(t("Go here"),"admin/plugin_manager/deps").t(" to resolve them."),"error");
  }

I did this, with no ill effects thus far.

Anonymous’s picture

Status: Needs review » Fixed

Removed in 6.x-1.x dev.

Anonymous’s picture

All dependency checking has been removed as it is outside of the scope of this module's purpose.

jaypan’s picture

Glad to hear that! Will you be rolling out a new version soon?

Anonymous’s picture

It will probably be several weeks. I'm focusing all of my effort (after my day job) into getting 6.x-2.x ready to release. It still has a way to go, but I think I'm close to preparing an alpha.

jaypan’s picture

Good luck!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.