Thickbox and Splash (repeated "close" text at the top)

imbalanced - September 28, 2009 - 15:38
Project:Splash
Version:6.x-2.5
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

This is from another issue which is now closed, but I'm getting the same thing. On the top-right corner is shown: Close,Close or Esc Key,or Esc Key. (Two times Close and 2x Esc key). Is there any way to fix this, even if it's a short term hack?

I'm currently using Thickbox 6.x-1.5 and Splash 6.x-2.5.

#1

imbalanced - September 29, 2009 - 15:53

I would like to add that I think it's probably a jQuery conflict. I'm currently using Lightbox2 for the entire website, including a photo gallery section. The only reason I'm using Thickbox at all is because it's the only one supported by Splash.

So yeah, currently I use Thickbox ONLY for the Splash implementation.

EDIT: The conflict isn't Lightbox2. I completely removed it from Drupal but Thickbox was still displaying the doubletext. The search continues!

#2

bara.munchies - September 29, 2009 - 09:09

i second that where to remove?

#3

seanr - October 5, 2009 - 20:57
Status:active» fixed

Found the problem and fixed it. I'll have a release up later today.

#4

dirksonii - October 13, 2009 - 13:38
Status:fixed» active

Pardon making this active again, but I think you forgot to release this particular fix, (either in a full release or even a dev release) and I wanted a quick reminder it was still a problem : )

#5

squares - October 22, 2009 - 19:28

It seems as though this behavior is caused by the function _thickbox_doheader in the .module being called multiple times.

I didn't have time to sort out why it would need to call the header more than once... but it was pretty apparent that the header was checking to see if it had already been added with this line:

       if ($already_added) { return; }

Unfortunately, it doesn't seem like this var is being set to true at any point.

So I changed
        STATIC $already_added = FALSE; 
to
        global $already_added;

and then made sure to set

        $already_added = TRUE;

at the very last line of the function.

Again, this may not be the correct fix for this... but if you have a 4pm deadline, and you need this functionality, it works :D

#6

PetarB - October 26, 2009 - 04:39

I've got this issue as well. I'll try the quick fix above and let you know how it goes.

#7

PetarB - October 26, 2009 - 04:52

Hmmm... maybe I'm missing something. I opened splash.module, and while I could find _thickbox_doheader, I could not see $already_added anywhere. Is is possible to get line numbers for the above fix? Thanks!

 
 

Drupal is a registered trademark of Dries Buytaert.