The depth set in a particular view seems to be ignored.
function tvi_render_view() seems to set it the $depth to zero without any arguments passed. Can we assign this depth from the view being read into the function?

I'm not sure the best way to do this - here's some code I added to both the "term override" and "vocab override" within tvi_render_view() that seemed to work. Please test it.

I changed:

			return views_embed_view($name, $display, $str_tids, $depth);

to 

if ($view_depth=$view->display[$display]->display_options['arguments']['term_node_tid_depth']['depth']) $depth = $view_depth;
			return views_embed_view($name, $display, $str_tids, $depth);

Comments

derekwebb1’s picture

derekwebb1 commented

Good catch... And thanks for the code! Will test and commit it if it checks out. Thanks again.

derekwebb1’s picture

derekwebb1 commented

Your code gets us most of the way there. Unfortunately, when there is a depth set, unless you override it in your preferred display, it is available only to the default display plugin. So passing in the $display actually botches the thing up...

Seems like a good fix might be to first check if there is a depth on the preferred plugin. If none is found (which is the case if you doi not override the default) then we can look to the default plugin.

That ought to do it

Thanks again. I will be working on this directly.

Derek

derekwebb1’s picture

derekwebb1 commented

I added a function for getting the depth from the view that seems to work ok. This should accommodate views tendency not to save depth info with all display plugins...

/**
 * Views only saves the depth to the default display if it is not overridden
 * in other displays.
 */
function tvi_get_view_depth($view, $display) {
  //  Depth set for preferred display plugin?
  $view_depth = $view->display[$display]->display_options['arguments']['term_node_tid_depth']['depth'];
  if ($view_depth === NULL) {
    // Depth set for default?
    $view_depth = $view->display['default']->display_options['arguments']['term_node_tid_depth']['depth'];
    if ($view_depth < 0 || $view_depth > 0) {
      return $view_depth; 
    }
  }
  return 0; // The default depth
}
jefftrnr’s picture

jefftrnr commented

Derek: I just tested your solution and just made a slight change to your function. See below.

/**
* Views only saves the depth to the default display if it is not overridden
* in other displays.
*/
function tvi_get_view_depth($view, $display) {
  //  Depth set for preferred display plugin?
  $view_depth = $view->display[$display]->display_options['arguments']['term_node_tid_depth']['depth'];
  if ($view_depth === NULL) {
    // Depth set for default?
    $view_depth = $view->display['default']->display_options['arguments']['term_node_tid_depth']['depth'];
    if ($view_depth < 0 || $view_depth > 0) {
      return $view_depth; // The depth for default display
    } 
    else {
      return 0; // The default depth
    }
  }
  return $view_depth; // The depth for preferred display
}
derekwebb1’s picture

derekwebb1 commented

Thanks! Glad you caught that.

You saved me another bug report!

Awesome.

[edit] Though the else part is not necessary

we can just have:

return 0;

right after the default plugin if conditional...

I will commit and tag these changes shortly.

derekwebb1’s picture

derekwebb1 commented
Status: Needs review » Closed (fixed)

Changes committed. Should be available in a few minutes.

Sinan Erdem’s picture

Sinan Erdem commented
Version: 6.x-1.x-dev » 6.x-1.1
Status: Closed (fixed) » Active

Tried the latest stable version of TVI (1.1), and when I set the depth of a views argument as +2, it ignores the depth and doesnt show the child nodes of a term...

derekwebb1’s picture

derekwebb1 commented

Sorry for the slow reply. Are you setting the depth in the view (Taxonomy: Term ID depth modifier) argument settings or elsewhere? Also, how many arguments are you using in your view. I think it may be limited to the two args described in the readme.txt if you want it to pass arguments. If that is the case then we may have to re-work some code!

Thanks, Derek

zarudnyi’s picture

zarudnyi commented

Same here. Depth of a view argument is allways 0 (Taxonomy: Term ID depth modifier).
Thanks.

rusdvl’s picture

rusdvl commented

I removed 'Taxonomy: Term ID depth modifier' from the view and only had the argument 'Taxonomy: Term ID (with depth)' and that fixed the issue for me...

derekwebb1’s picture

derekwebb1 commented
Status: Active » Closed (works as designed)