Closed (fixed)
Project:
Persistent URL
Version:
6.x-1.0-beta10
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Sep 2009 at 18:03 UTC
Updated:
7 May 2010 at 22:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
jmiccolis commentedI'm fairly sure that patch doesn't address the core issue here. The problem is that once you change the subdomain you're effectively removing the current subdomain from purls memory. So on form submission purl assumes that it's not a part of the domain it's responsible for. Thus you get two subdomains.
I'm not sure the best way forward here. Attached is a patch that checks the domain against the 'purl_base_domain' and it they match it doesn't remove any elements. This will work well so long as your base domain is never one of your purl domains. I haven't used the prefix system in production so I'm simply not sure if it's fair to assume that you'll always want a not treated domain as your base.
Comment #2
socialnicheguru commentedfollowing
Comment #3
socialnicheguru commentedhas this also been committed to purl?
Comment #4
socialnicheguru commentedThis is needed for purl to work with url_alter
Comment #5
TKS commentedThat patch from jmiccolis was not committed in the latest version (6.x-1.0-beta10), and the code in question now lives in purl/includes/purl_subdomain.inc, instead of purl.module itself.
The patch attached here implements the same code tweaks in that new file. It's working fine for me on a test install right now, but the testing so far has been very quick and cursory.
Hope this helps...
Comment #6
yhahn commentedThanks, committed with adjustments: http://drupal.org/cvs?commit=358690