Division by zero in fivestar.module on line 1398

j0sh - October 2, 2009 - 11:15
Project:Fivestar
Version:6.x-1.18
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

hi
sometimes i get this error
Division by zero in /storage/httpd/drupal/iwikiphone/sites/all/modules/fivestar/fivestar.module on line 1398.

#1

j0sh - October 2, 2009 - 15:36

this patch could resolve the problem

AttachmentSize
division_by_zero.patch 539 bytes

#2

ezra-g - October 4, 2009 - 15:42
Priority:critical» normal

Thanks for this patch. The indentations you're using are not compliant with the Drupal coding standards. Also, I'm not sure that we need to set the rating value.

Does the attached patch resolve the problem for you?

AttachmentSize
fivestar-594062.patch 796 bytes

#3

ezra-g - October 4, 2009 - 16:05
Status:active» needs review

#4

j0sh - October 4, 2009 - 17:09

yes this solved my problem... sorry for indentation

#5

ezra-g - October 4, 2009 - 17:16
Title:Division by zero again» Division by zero in fivestar.module on line 1398
Status:needs review» fixed

No problem -- Just wanted to point you in the right direction. Thanks for the quick review! Comitted.

#6

System Message - October 18, 2009 - 17:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.