Closed (fixed)
Project:
CVS integration
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Anonymous (not verified)
Created:
20 Apr 2006 at 00:35 UTC
Updated:
19 Aug 2015 at 15:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nedjoThis is now fixed.
Comment #2
Anonymous (not verified) commentedthanks
Comment #3
(not verified) commentedComment #4
dwwthis is really a bug in the cvs.module. it's still active, and easily reproducable, both on drupal.org and on a test site. it's crazy to use a multiselect widget for this, since there should only be 1 valid choice per project, anyway. i'll try to roll a quick patch to make this a drop-down (that defaults to contributions) and see if that fixes things.
Comment #5
dwwheh, trivial fix. there was confusion over what the field name was supposed to be ('cvs_repository' vs. 'repository'). by making everything consistent ('cvs_respository') it all works now. while i was at it, i turned this into a drop-down select instead of a multi-select, since there should only ever be 1 repository for a given project.
Comment #6
dwwand here's the holy grail patch for this bug. ;) now, there are a few new options in admin/settings/cvs:
'Default CVS repository for projects' (radio select for all repo names) and 'Projects that can select their CVS repository' (autocomplete text field for comma-separated list of project titles). i heavily stole from taxonomy_autocomplete() to get this project_autocomplete() working, happy with the commas, etc. any projects not in this text field can *not* select their repo, and will be forced to use the default repo.
the idea is that the drupal project itself would be listed in there, and would then be allowed to select the "drupal" repo. otherwise, everything would just have a select box with a single option for 'contributions'. it's pretty slick. ;) try it out. i think this is definitely the way to go for drupal.org, yet i tried to keep it flexible enough to be useful for other sites, too.
Comment #7
Anonymous (not verified) commentedtested.. +1
Comment #8
killes@www.drop.org commentedlooks good but I don't have a test setup.
Comment #9
dwwafter consultation w/ killes in IRC, i applied the patch from #6 to HEAD and backported the project specific changes (which is just the autocomplete callback) to DRUPAL-4-7. still needs to be updated onto drupal.org. i'm therefore leaving the status as RTBC. we talked about maybe reviving scratch.drupal.org as a test bed for this stuff...
Comment #10
dwwkilles updated drupal.org. seems to be working now.
Comment #11
dwwugh, bug in that last patch. here's the fix.
Comment #12
dwwtypo in the last patch. this one's been tested now. sorry. (that's what i get for trying to rush this stuff).
Comment #13
dwwpatch from #12 applied as revision 1.104.
Comment #14
dwwComment #15
(not verified) commented