Same issue with stable versions

thepiano - October 6, 2009 - 08:04
Project:Thickbox
Version:6.x-1.5
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Drupal Core 6.14
CCK 6.x-3.x-dev (2009-Oct-05)
Emfield 6.x-1.x-dev (2009-Oct-06)
Thickbox 6.x-1.x-dev (2009-Sep-08)

> Content Type - Article
> Article has an Emfield embedded video field (let's call it vField)
> Display Field for vField set to "Thickbox: Image Thumbnail > Full size video"

Observations:
1. In FF, loading animation (that greyish rectangular progress bar) is displayed but the contents of the page suddenly got shifted left by about 30px, and the video never loads.
2. In Opera, the same thing is observed.
3. In Safari, the video actually loads.

The videos are able to play in FF, Opera, and Safari previously, using the same settings I mentioned above. I was wondering if it has anything to do with updating Emfield to its latest version.

Any idea what is going on?

Thank You.

#1

frjo - October 6, 2009 - 11:36

Since you are running dev-code for all the modules I'm not surprised that you have problems.

Please try running the latest stable versions of the modules instead.

#2

Eric At NRD - October 9, 2009 - 10:56
Title:Video not loading in FF, Opera, but Mac can» Same issue with stable versions
Version:6.x-1.x-dev» 6.x-1.5

I am seeing the same behavior as described above with stable versions of the modules listed:
Drupal Core 6.14
cck-6.x-2.5
emfield-6.x-1.11
thickbox-6.x-1.5

It started immediately after upgrading Emfield to 6.x-1.11. However, if I disable Thickbox, videos still display properly, so it is not clear to me if the problem lies with Emfield, or Thickbox.

There is more discussion on this in the Emfield issue queue as well: http://drupal.org/node/593030

#3

frjo - October 10, 2009 - 07:37

Is there an example page we can test this on?

#4

Eric At NRD - October 12, 2009 - 19:08

frjo, I ran into this problem on a public site, so I disabled Thickbox on the site (since it effectively made an entire section of the site unusable). However, if no-one else can provide a link, I will set up a temporary site in the next day or so and see if I can duplicate the problem.

A variable in the mix that I don't think has been explicitly mentioned yet is that the problem appears to be when using Views to generate a link from an emfield thumbnail to the video.

Thank you for your help.

#5

renee - October 13, 2009 - 02:50

I get this in firebug:

tb_position is not defined
tb_position();\n

... if that helps.

@frjo: I get it with EMField 1.11 and Thickbox 1.5, stable versions. So the devs are clearly not the problem.

#6

Eric At NRD - October 13, 2009 - 16:17

@frjo: I set up a page where you can view the issue on a live site at http://gleedo.com/use_gleedo/tutorials/testing

The styling is a little funky since it is just for testing purposes, but I think it should be fine for testing and debugging.

The page is generated via views, with the thumbnail fields set to "Content: Video Thickbox: Image Thumbnail -> Full Size Video". Clicking on them generates a progress-bar that never resolves, and the following console errors (via Firebug) that are similar to the ones @renee observed:

$.browserextra is undefined
tb_position()testing (line 326)
anonymous()thickbox.js?Q (line 269)
anonymous()jquery.j...val/seq/1 (line 1)
anonymous()jquery.j...val/seq/1 (line 1)
anonymous()jquery.j...val/seq/1 (line 1)
complete()jquery.j...val/seq/1 (line 1)
anonymous()jquery.j...val/seq/1 (line 1)
[Break on this error] (326 out of range 293)

#7

frjo - October 13, 2009 - 18:42

I also get the "$.browserextra is undefined" error on the gleedo example page.

It looks like the emvideo build incorrect links for Thickbox

They look like this:

http://gleedo.com/emvideo/modal/116/425/350/field_video/youtube/X8H49WA3Ybw

But should be like this:

http://gleedo.com/emvideo/modal/116/425/350/field_video/youtube/X8H49WA3Ybw?TB_iframe=true&height=350&width=425

It is the "TB_iframe=true" part that is most important. The width and height is optional, if they are missing Thickbox falls back to its default values. It looks nicer if the thickbox window only is as big as the content.

#8

frjo - October 13, 2009 - 19:02

Here is a patch you an try put on the example site. OBS it is not tested so do not test it on a production site.

If it works feel free to submit it to the emfield/emvideo issue queue.

AttachmentSize
emfield_thickbox.patch 846 bytes

#9

Eric At NRD - October 13, 2009 - 19:55

Hi frjo,

Thanks for looking into this. Does your response mean that you were able to view the video, albeit with a Thickbox window that is the wrong size)? The video never loads for me in Firefox3, or IE8.

I'm pretty certain that Emfield has not included GET variables in its links in any recent versions, but the video still at least displayed until version 1.11.

#10

Eric At NRD - October 13, 2009 - 20:04

Thanks frjo, I didn't see your patch when I wrote comment #9. I'm setting up a test site now to try this out. I'll get back to you ASAP.

Thanks for your help!

#11

Eric At NRD - October 13, 2009 - 20:23

@frjo, sure enough, your patch did the trick! Thank you for your help.

I'm posting your patch to the Emfield issue queue where this is also being discussed: http://drupal.org/node/593030

Thank you again.

#12

frjo - October 14, 2009 - 06:49
Status:active» fixed

Happy to here it worked.

Some resent changes to thickbox.js (like adding $.browserextra) probably made the incorrect links in emvideo break.

#13

System Message - October 28, 2009 - 06:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.