Closed (fixed)
Project:
Bibliography Module
Version:
6.x-1.7
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Oct 2009 at 13:44 UTC
Updated:
26 Jan 2010 at 03:37 UTC
I cannot create new biblio objects. I go to the page "/node/add/biblio" and select the publication type (for example Book). After that the view doens't give me any new options and not even a save button. (See attachment)
Existing biblio objects can be edited all right. This came up to me when I updated to Drupal 6.14. but I'm not sure if it is related to this problem.
This occurs at least with versions 6.x-1.6 and newer.
Sorry for the localized screenshot. It says on the top as error message: "Title field is compulsory". Page title is: "Create biblio content".
---------
For a smaller matter, there is an unclosed short tag in biblio.module on line ~1050
'#suffix' => '
| Comment | File | Size | Author |
|---|---|---|---|
| attachment.png | 8.7 KB | teelmo |
Comments
Comment #1
Frank Steiner commentedConfirmed. The problem is in the encoding. The code of the biblio form looks like this:
So there must be an additional step somewhere (likely in drupal 6.14) which transforms the single quotes into their html tags. I've no idea where it comes from, but it's real problem. We also cannot add any publications.
Comment #2
rjerome commentedI don't think it's an issue with 6.14, since I'm running that on my production site and it works fine. Also, my test site is running 6.9 and it produces the same encoding as shown above.
I've tried it with both FF and IE browsers, what are you using?
Comment #3
Frank Steiner commentedFirefox 2 and 3 and Opera 10, both Linux. I can however confirm that it happened without any change to biblio, I was still running the 1.1 version while only upgrading drupal itself from .12 to .13 to .14. I'm pretty sure it happened from .13 to .14 because we regularly enter new publications and we would have realized if it didn't work with drupal 6.13 already.
Very strange :-(
I don't fully understand the mechanism here: where's the submit function defined that is to be called by the onchange action? Should it biblio_form_submit or sth.? I only find the validate function for the form in biblio.module.
Comment #4
rjerome commentedStrange indeed since it doesn't do it on my 6.14 installation. Are you using any caching?
That's a bit of a hack, it's basically clicking the submit ("Save") button when the user changes a publication type. In the validate code, it checks to see if the user has changed the "type" since the last time through, if not then it is submitted, otherwise the form is just rebuilt ( $form_state['rebuild'] = TRUE;) ...
Comment #5
Frank Steiner commentedNo, any kind of caching is disabled. With some debugging messages I can see that the validate function comes into the rebuild case, but I've put a "print" and "drupal_set_message" into biblio_form. Those are printed when I enter the node/add/biblio page the first time, but it's not issued again when select a type.
Thus, it seems the form is not really rebuilt.
Comment #6
Frank Steiner commentedOk, it is a problem of 6.14. I just wonder why it does not happen for everyone. A patch for 6.14 that works for me is in http://drupal.org/node/591696
Discussions of this problem are in
http://drupal.org/node/587254
http://drupal.org/node/584536
http://drupal.org/node/302240
Comment #7
rjerome commentedThanks for tracking that down Frank.
Still not sure why I'm not seeing that on my installation, I'll have to check that core forms file and see if it has the changes mentioned above.
Ron.
Comment #8
teelmo commentedHave you come up in any solutions. Even a hack or patch?
I tried to modify the code @ /biblio/biblio.module on line ~1450
But i didn't get any working results. All thought it seems that debug messages are printed from that else sector.
Any ideas ? I have none :)
Comment #9
teelmo commentedI can also say that it doesn't work with Google Chrome either. I have also tried it with two different Linux servers and the functionality that it won't work appears on both.
And to make it clear I also noticed this when Drupal was upgraded from 6.13 to 6.14.
Comment #10
rjerome commentedThis is definitely a problem introduced in 6.14 see comment #6. It has to do with the fact that I'm using a technology called AHAH (Asychronous HTML and HTTP) on the form. Hopefully it will be resolved in 6.15.
Ron.
Comment #11
Frank Steiner commentedThe bug is marked a release-stopper for 6.15
Comment #12
bekasu commentedupgrade to drupal 6.15.
marking issue closed.
bekasu