oliverhuynh [oliverhuynh]

Using Google I found many modules and ways to redirect after login. Do we need another?

1. version = "1.0"
   core = "6.x"
   project = "destination_login"
   datestamp = "1236442546"
   

   That part should be removed, as it is added from the packaging script.

2. See the Drupal coding standards to understand how a module code should be written.
3. I agree with AjK that there are already too much modules with the same purpose.
   See what reported on Apply for contributions CVS access:

   It's important to note that CVS applications are often denied when a tendered module duplicates the features and functions of an existing module and in these cases applicants are referred to the module's maintainer to offer collaboration on improving that existing module.

You didn't upload the new code.

1.     if(arg(0) != "user")
         return ;
   

   The code is not formatted as suggested by the coding standards (this is a very minor issue).

2. I still have doubts about what the module does. What does the code do that is different from what Drupal core code already does? Using the action Redirect to URL and triggering it when the user logs in, I could obtain the same result.

I will leave to somebody else the decision about this CVS application.

1. Go to http://drupal.org, and log out, if you are logged in.
2. Visit http://drupal.org/node/598774 (without to first close the browse).
3. You will see a block that you can use to log in in Drupal; enter your user name and password; click on the button to log in.
4. You will notice that you are still in the page you were watching before to log in (http://drupal.org/node/598774).

Then, what is the difference with what your module does?

As I said, I will leave the decision about this module to somebody else; differently I will be once again said to be despotic (you can always thank the user who said such thing, if your application will wait for somebody else approval).

Also, I apologize if inadvertently my words, or my tone could result offensive for you. It's not my intention to offend, and my task is only to verify if a module / theme is worth to be placed in Drupal.org CVS, and if to approve CVS applications made from people. I don't judge the person who is applying for a CVS account in any way.

I understood what your module does; still, the difference is between having a block (which is then handled by Drupal core code), or not having it displayed.

To notice that I have not spoken of the second option, Drupal actions.

As I have already made my point, I will stop in explaining it any further before to get boring.
To notice that two of all the persons who approve CVS applications have already raised doubts about the proposed module; that doesn't mean anything, and somebody else who approves applications can have a different opinion (and maybe s/he can approve this application).

Basing on the last comment, I am marking this report as won't fix.