The product description shown in cart doesn't display attributes in their weight order.

This is actually a really silly bug, the attributes are being sorted into the correct order, but never actually being returned.

One line fix.

diff --git uc_attribute/uc_attribute.module uc_attribute/uc_attribute.module
index a73683e..3cbdc76 100644
--- uc_attribute/uc_attribute.module
+++ uc_attribute/uc_attribute.module
@@ -477,6 +477,7 @@ function uc_attribute_cart_item($op, &$item) {
         }
       }
       ksort($combination);
+      $item->data['attributes'] = $combination;

       $result = db_query("SELECT model FROM {uc_product_adjustments} WHERE nid = %d AND combination LIKE '%s'", $item->nid, serialize($combination));
       $model = db_result($result);

Finally, somebody else that has this issue. I thought I botched something in the module itself playing around. I am going to attempt this patch and will report my findings.

No luck. The above poster is correct. Will keep trying as well.

This is frustrating. This issue has been around since 2008 and really needs to be addressed. Is anyone out there that is up to taking this on? It may end up being a simple fix, but I cannot see it.

The status for an issue that has a solution but doesn't work is usually "needs work" not "active".

The product description is generated through the drupal_render function, the following patch adds a weight to the form items, so that drupal_render will observer the order they are in.

Nice simple solution that handles default ordering (while still allowing overrides through hook_product_description_alter()).

The code to document hook_product_description() in hooks.php will also have to be updated as it's simply a copy of uc_attribute_product_description().

d6.14
u 2.2

thank you this seems to work

why is not fixed in ubercart???

still shows in random unsorted order when viewing
Home › Store administration › Orders

Here's a patch to change the docs.php function as well. Changing the order of attributes at the product level still won't affect products that are already in the cart, but I think it's better than it was.

Thanks, and committed.

This issue still exists in 6.x-2.2, (released before IslandUsurper's commit in #12.)

The patch in #12 applies cleanly to 6.x-2.2 and does what it's supposed to.

subscribing

Can I use this patch in 2.3? Am a complete novice and not sure where I should be putting this code. Thanks, Natalie

subscribing

There's nothing to subscribe to here. This patch was committed 24th Nov 2009, it's part of Ubercart 2.3 and above.

Incorrect. This issue still exists in 2.4. In 2.4 it lists them in order BACKWARDS.

@crystaldawn: I cannot reproduce this. I created a new product with new attributes and added that product to my cart. The attributes are shown in alphabetical order on the product view page, the cart page, and the checkout page. I removed that product from my cart. I then modified the order of the attributes at node/%/edit/attributes and again added the product to my cart (after saving the attribute changes). The product view page, the cart page, and the checkout page all show the attributes in the new order.

If you still think there is a bug please open a new issue, describe what you expect to happen and what actually happens, and document all the steps that need to be taken to reproduce the issue.

Added some attributes to a node.
Added the resulting product to a cart.

Put the following debug code on line 1838 and 1839 in uc_product.module:

function uc_product_get_description($product) {
  // Run through implementations of hook_product_description()
  $description = module_invoke_all('product_description', $product);

  // Now allow alterations via hook_product_description_alter()
  drupal_alter('product_description', $description, $product);

//Debug the out of order issue.  $description seems to be correct, but drupal_render($description) is clearly wrong!
  print_r($description);
  print_r(drupal_render($description));
  exit;
  return drupal_render($description);
}

And this was the result. Notice how the attributes are correct in the array, but after they are run through drupal_render, they come back as OUT of order?! Erm. Ok, so the bug seems to be fixed in the array, but now drupal render is causing an issue. I am in the process of debugging drupal_render now to find out why it's sending back the array out of order, but something tells me that this problem is affecting others whether they realize it or not. The order in which they are returned is not in the order of the array keys (which is NOT determined by alphabetical which you suggested, it's determined by WEIGHT which would be the correct method. Alphabetical would be completely incorrect anyways even if it did do it that way because they are suppose to be sorted by weight as not all instances would want them alphabetical as shown here by this example use case) as they are suppose to be.

Array
(
    [attributes] => Array
        (
            [#product] => Array
                (
                    [#type] => value
                    [#value] => stdClass Object
                        (
                            [cart_item_id] => 375
                            [cart_id] => 1
                            [nid] => 19
                            [qty] => 1
                            [changed] => 1303444769
                            [data] => Array
                                (
                                    [attributes] => Array
                                        (
                                            [1] => 1
                                            [2] => 8
                                            [3] => 16
                                            [4] => 29
                                        )
 
                                    [shippable] => 1
                                    [module] => uc_product
                                )
 
                            [title] => doc popcorn BIG tin
                            [vid] => 19
                            [cost] => 0
                            [price] => 40
                            [weight] => 4
                            [module] => uc_product
                            [model] => Big Tin
                        )
 
                )
 
            [#theme] => uc_product_attributes
            [#weight] => 1
            [1] => Array
                (
                    [#attribute_name] => Tin Color
                    [#options] => Array
                        (
                            [0] => Silver
                        )
 
                )
 
            [2] => Array
                (
                    [#attribute_name] => First Flavor
                    [#options] => Array
                        (
                            [0] => salt-n-pepper
                        )
 
                )
 
            [3] => Array
                (
                    [#attribute_name] => Second Flavor
                    [#options] => Array
                        (
                            [0] => triple white cheddar
                        )
 
                )
 
            [4] => Array
                (
                    [#attribute_name] => Third Flavor
                    [#options] => Array
                        (
                            [0] => sinfully cinnamon
                        )
 
                )
 
        )
 
)
<div class="item-list"><ul class="product-description"><li class="first">Second Flavor: triple white cheddar</li> 
<li>Third Flavor: sinfully cinnamon</li> 
<li>First Flavor: salt-n-pepper</li> 
<li class="last">Tin Color: Silver</li> 
</ul></div>

Please open a NEW issue like I asked, and provide the information I asked for.

removed

erm, ok. was in process of putting more debug stuff when u wrote that :P

Back to "Closed (fixed)"