Closed (fixed)
Project:
Views Datasource
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
15 Oct 2009 at 07:23 UTC
Updated:
16 Nov 2009 at 00:10 UTC
Jump to comment: Most recent file
I love this module so much that I've taken the time to improve the formatting and commenting of it according to the recommendations of the Coder and Coder Tough Love modules. This patch just focuses on spacing adjustments, some comment changes, and a couple minor formatting tweaks. This is the first time I've made and submitted a patch. So, hopefully I'm doing this right !
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 605082_coder_revew_views_datasource.patch | 96.63 KB | greggles |
| views_datasource_alpha3_001.patch | 94.02 KB | icylace |
Comments
Comment #1
gregglesUpdated so that it will apply more cleanly.
Comment #2
icylace commentedThanks for making it cleaner. What's the proper way to make a patch ?
Comment #3
icylace commentedThanks for making it cleaner. What's the proper way to make a patch ?
Comment #4
gregglesSee http://drupal.org/patch/create
Basically I created it against cvs using "cvs diff -up" instead of doing it against two local directories.
Comment #5
allisterbeharry commentedCommitted here: http://drupal.org/node/616576