higher compliance with coding standards

icylace - October 15, 2009 - 07:23
Project:Views Datasource
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:allisterbeharry
Status:closed
Description

I love this module so much that I've taken the time to improve the formatting and commenting of it according to the recommendations of the Coder and Coder Tough Love modules. This patch just focuses on spacing adjustments, some comment changes, and a couple minor formatting tweaks. This is the first time I've made and submitted a patch. So, hopefully I'm doing this right !

AttachmentSize
views_datasource_alpha3_001.patch94.02 KB

#1

greggles - October 21, 2009 - 20:02
Version:6.x-1.0-alpha3» 6.x-1.x-dev
Status:active» needs review

Updated so that it will apply more cleanly.

AttachmentSize
605082_coder_revew_views_datasource.patch 96.63 KB

#2

icylace - October 28, 2009 - 03:36

Thanks for making it cleaner. What's the proper way to make a patch ?

#3

icylace - October 28, 2009 - 03:37

Thanks for making it cleaner. What's the proper way to make a patch ?

#4

greggles - October 28, 2009 - 04:40

See http://drupal.org/patch/create

Basically I created it against cvs using "cvs diff -up" instead of doing it against two local directories.

#5

allisterbeharry - November 2, 2009 - 00:03
Assigned to:Anonymous» allisterbeharry
Status:needs review» fixed

Committed here: http://drupal.org/node/616576

#6

System Message - November 16, 2009 - 00:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.