Download & Extend
Views Datasource » Issues

higher compliance with coding standards

Posted by icylace on October 15, 2009 at 7:23am
Project:Views Datasource
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:allisterbeharry
Status:closed (fixed)

Issue Summary

I love this module so much that I've taken the time to improve the formatting and commenting of it according to the recommendations of the Coder and Coder Tough Love modules. This patch just focuses on spacing adjustments, some comment changes, and a couple minor formatting tweaks. This is the first time I've made and submitted a patch. So, hopefully I'm doing this right !

AttachmentSize
views_datasource_alpha3_001.patch94.02 KB
Login or register to post comments

Comments

#1

Posted by greggles on October 21, 2009 at 8:02pm
Version:6.x-1.0-alpha3» 6.x-1.x-dev
Status:active» needs review

Updated so that it will apply more cleanly.

AttachmentSize
605082_coder_revew_views_datasource.patch 96.63 KB

#2

Posted by icylace on October 28, 2009 at 3:36am

Thanks for making it cleaner. What's the proper way to make a patch ?

#3

Posted by icylace on October 28, 2009 at 3:37am

Thanks for making it cleaner. What's the proper way to make a patch ?

#4

Posted by greggles on October 28, 2009 at 4:40am

See http://drupal.org/patch/create

Basically I created it against cvs using "cvs diff -up" instead of doing it against two local directories.

#5

Posted by allisterbeharry on November 2, 2009 at 12:03am
Assigned to:Anonymous» allisterbeharry
Status:needs review» fixed

Committed here: http://drupal.org/node/616576

#6

Posted by System Message on November 16, 2009 at 12:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here