Add status filter for plural/not plural

+++ l10n_community/translate.inc	15 Oct 2009 11:47:23 -0000
@@ -693,7 +704,13 @@ function l10n_community_get_strings($lan
+  if ($filters['status'] & L10N_STATUS_HAS_PLURAL) {
+    $where[] = "LOCATE(CHAR(0), s.value) > 0";
+  }
+  elseif ($filters['status'] & L10N_STATUS_NO_PLURAL) {
+    $where[] = "LOCATE(CHAR(0), s.value) = 0";
+  }

This code fragment pretty much shows why this approach fails badly. If we use LOCATE(), the database will need to run this function on each row, which prohibits using any indexes.

I'd say we'd rather cache this data in a column and do this calculation only once when the source string is inserted into the database.

This review is powered by Dreditor.

Much better direction IMHO! The patch does not add the field to fresh installs though.

subscribe

Retitled. There are basically two things which make me hesitant to load in more filters: #581342: String filter form too wide and that the indexes on the tables are not performing well for the current wide ranging filters already (think database query performance). It is probably not possible to optimize for use of arbitrary filters, so we need to balance flexibility and speed.

Ok, I think the latest UI changes make it possible to add these filters more easily. Let's do it.

Added #1118430: Set up the filtering/display setting UI for future growth to set us up for filter extensions like this.