Closed (fixed)
Project:
Internationalization
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 Oct 2009 at 16:34 UTC
Updated:
17 Nov 2009 at 19:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
sinasalek commentedi18ntaxonomy_taxonomy is available and has most of the require functionality for complete taxonomy synchronization. but it does not work the it's suppose to.
PS : To i18n maintainers : i need advice about this , please correct me if i'm heading to a wrong direction :) tx
Comment #2
sinasalek commentedComment #3
jose reyero commentedFixed most of this synchronization issues, see #379306: Synchronize translations for taxonomy terms not working (content type setting)
Still not fixed: tags (patches welcomed)
@sinasalek,
Thanks for putting together these issues, and for the heads up.
Comment #4
sinasalek commentedJose,
Glad that i didn't start :). I'll test the latest version again and report back. (would you please update the dev snapshot if it's possible?)
Guess i can prepare a patch for tags, since i'm using it on my own site.
Thanks.
Comment #5
sinasalek commentedI just tried the dev snapshot, it works perfect for regular taxonomies , good job Jose.
However it sets Tags taxonomies of translation node to 0! i think the proper way is to ignore this type of taxonomy when it's not supported.
Comment #6
sinasalek commentedI did it, it works on my own site, it needs a little bit cleanup but i need a maintainer to see it cause i'm not sure if i've implemented it in proper way.
Thanks
Comment #7
sinasalek commentedI had some time today to test the dev version again. i wanted to test mode "Localize terms." and it works just fine, but i expected to see category follows node's language , but it follows page language. so the node language might be English but when it appears in German page, categories are in German. However it's not important for me , just wanted to share the result of my test.
There is author problem which i has not cause any problem for me , but it looks like that somewhere there is a wrong query which i guess might cause some problems. when i save a node which is synchronizable i always see this message which is wrong because there is a translation node attach to this node :
All 0 node translations have been synchronized.
I might fix the second issue on my patch.
Comment #8
sinasalek commentedIt seems that term names are not unique even per each vocabulary. so i modified the patch and now it returns the lightest term (sorted by weight) when it tries to find term by its name.
There was also another issue which is resolved in this patch. since users are allowed to enter non existence terms in tags vocabulary it could cause some other issues.
I also fixed some small issues and added more comments. i think it's now in a good shape. please try it and let me know you opinion.
Comment #9
sinasalek commentedComment #10
sinasalek commentedI found another issue in i18ntaxonomysync module, Vocabulary name can be translated via interface translation but it does not show up anywhere.
Comment #11
jose reyero commentedFixed the tag support a bit easier. Now, instead of handling complex form submissions, we reload a clean taxonomy array for the node before synchronizing ($node->i18ntaxonomy).
This should work for all kind of vocabularies now. Please confirm.
Comment #12
sinasalek commentedDid you apply my patch?, or you fixed it yourself?
Comment #13
sinasalek commentedOh, i see.i checked the source code, looks good. thanks. i'm testing it right now.
Comment #14
sinasalek commentedTags works very well,
Localize terms works
Per language terms works.
There are still few issues like translating vocabulary names. i'll open a new issue for each one
Good job jose thanks.