Taxes not being calculated and added

See http://drupal.org/node/39653

Does your rule look like this?
Add 7.00% where country = 'ca'

Yes GST should be working regardless. Sorry I don't know what's wrong as it's working on my setup. :-(

Taxes are based on the billing address.

I discovered this is because the tax only gets added to "shippable" items, which might be the expected behaviour for normal tax but doesn't work for GST countries.

To make the tax apply to all products:

Lines 56 - 60 of tax.module
Before

      foreach ($txn->items as $item) {
        if (product_is_shippable($item->nid)) {
          $taxable_amount += product_adjust_price($item) * $item->qty;
        }
      }

After

      foreach ($txn->items as $item) {
        //if (product_is_shippable($item->nid)) {  <-- Remove this
          $taxable_amount += product_adjust_price($item) * $item->qty;
        //}  <-- Remove this
      }

Would be good to make this a module setting or something.

the tax module needs to re done so that it can handle the more complex tax modules. The current system will not do VAT which is similar to GST but more complicated.

See http://drupal.org/node/75339 for a new temporary solution to this problem.

We are not supporting 4.6 now. Putting to HEAD to keep history

fixing component

Attached is a patch which removes check which causes tax to be only calculated for 'shippable products'. Another possible approach would be to simply have an option in the tax module settings which enables tax to be enabled / disabled for shippable products only.

Either way, this restriction on when to apply tax needs to be clearer to the Drupal administrator. I spent an hour trying to figure out what was wrong with my products when some had tax and other didn't. I expect there would be many others out there in Drupal E-Commerce land experiencing the same confusion.

Please review :)

I will not be applying a patch like this or it will break all the installs that rely on this set up.

In v4 the tax module is going to be removed and this is going to be handled by flexicharge.

Thanks for the response Gordon.

I am trying to apply the Australian GST tax to all purchases in Australia. Tax does this, however Flexicharge does not. With Flexicharge I can only set up: sitewide charges and shipping charges. Neither is applicable since I need to apply GST to only those purchases in Australia.

Can you explain how Flexicharge would be used to calculate GST for sales?

OK I think I get it now, Flexicharge plus a custom Flexicharge provider module to calculate the GST tax is required. Found this here on the Creating a custom flexicharge page, http://drupal.org/node/123026.

Surprised no one has written one already :)

inactive for 1 year+
please reopen if needed.

Thanks,
DaveA