More detailed log

Also would be great to have an admin page showing each feed, last time updated, etc... nice quick browse page for admins.

+1 Subscribe

This is a quick port. It's still using views 3. There should probably be logging added to processors besides the node processor or we could move it into FeedsProcessor. Tests pass.

Looks like a good improvement; maybe I'll test tomorrow, but I would have to upgrade to Views 3.

Would it be out of scope to add logging of feed import times to this patch? I'm trying to figure out how long it takes for my feeds to import, to assess the scalability of the system. See http://drupalbin.com/18789 for how I'm trying to do it.

It looks like if I could get access to the currently active $importer, I could at least log the importer title using $importer->config['name'];. But could I also get the number of nodes imported?

If I'm not mistaken, it looks like the issue marked duplicate at #948936: Add watchdog entry on node create/update to show how many created/updated is not actually in the committed patch, or the one for 6.x. Am I correct?

Here's some code that adds more detailed logging for nodes created/updated. The only thing I haven't figured out yet is how to get the name of the feed from which the nodes are being imported:

  public function process(FeedsImportBatch $batch, FeedsSource $source) {
    timer_start('feeds_import');		
    // Keep track of processed items in this pass, set total number of items.
    $processed = 0;
    if (!$batch->getTotal(FEEDS_PROCESSING)) {
      $batch->setTotal(FEEDS_PROCESSING, count($batch->items));
    }

    while ($item = $batch->shiftItem()) {
    // snip the loop code...
    }
    $timer_value = timer_stop('feeds_import');
    $import_time = $timer_value['time'] / 1000;

    // Set messages. (Evan: added logging to watchdog.)
    // TODO: The @feedname information is not here - find out how to get access to the $importer->config.
    if ($batch->created) {
      drupal_set_message(format_plural($batch->created, 'Created @number @type node.', 'Created @number @type nodes.', array('@number' => $batch->created, '@type' => node_get_types('name', $this->config['content_type']))));
      watchdog('feeds', 'Feeds module created @number @type nodes from @feedname feed in @time seconds', array('@time' => $import_time, '@number' => $batch->created, '@type' => $this->config['content_type'], '@feedname' => $this->config['name']), WATCHDOG_DEBUG);
    }
    elseif ($batch->updated) {
      drupal_set_message(format_plural($batch->updated, 'Updated @number @type node.', 'Updated @number @type nodes.', array('@number' => $batch->updated, '@type' => node_get_types('name', $this->config['content_type']))));
      watchdog('feeds', 'Feeds module updated @number @type nodes from @feedname feed in @time seconds', array('@time' => $import_time, '@number' => $batch->created, '@type' => $this->config['content_type'], '@feedname' => $this->config['name']), WATCHDOG_DEBUG);
    }
    else {
      drupal_set_message(t('There is no new content.'));
      watchdog('feeds', 'There was no new content in @feedname', array('@feedname' => $this->config['name']));
    }
    $batch->setProgress(FEEDS_PROCESSING, FEEDS_BATCH_COMPLETE);
  }

This is the patch from #12 updated to latest head with Views 2 support.

looks like some of this got in already, so I'm marking this postponed until it's sorted out.

Not interesting in backporting this anymore.