Auto Assign role display an tab with an empty link on login page

Posted by gagarine on October 17, 2009 at 9:43am

Issue Summary

If you use auto assign role with path but any path replace the normal register page, /user/register tab is still present but without any thing inside. This is a problem for theming...

The html code of the tab on /user page

<ul class="tabs primary clearfix">
   <li><a href="/en/user/register"><span class="tab"></span></a></li>  <<<---- EMPTY LINK
  <li class="active"><a href="/en/user" class="active"><span class="tab">Log in</span></a></li>
   <li><a href="/en/user/password"><span class="tab">Request new password</span></a></li>
</ul>

Comments

#1

Posted by AllRob-deleteplz on October 23, 2009 at 6:55am

confirmed, i have the same 'bug'.

On a clean install i've set up a page as the default register page, the node has a title, as soon as i save the form the register button is empty.

html output looks the same as the above.

#2

Posted by mr.baileys on October 29, 2009 at 4:50pm

Priority:

minor

» normal

In autoassignrole_menu_alter(), the "user/register" item is overwritten instead of changed, essentially removing the tab title (and other information). Replacing the code near the end of the function with a merge fixes the issue:

if ($path) {
  $items['user/register'] = array_merge(
    array(
      'page arguments' => array($path),
      'page callback' => 'drupal_goto',
      'access callback' => 'user_register_access',
      'type' => MENU_LOCAL_TASK,
    ), 
    $items['user/register']
  );
}

an alternative would be:

if ($path) {
  $items['user/register']['page arguments'] = array($path);
  $items['user/register']['page callback'] = 'drupal_goto';
  $items['user/register']['access callback'] = 'user_register_access';
  $items['user/register']['type'] = MENU_LOCAL_TASK;
}

#3

Posted by cyberswat on October 29, 2009 at 8:44pm

ok ... great ... can you roll a patch so it can be tested?

#4

Posted by mr.baileys on November 2, 2009 at 12:03pm

Status:

active

» needs review

Sure, patch against head attached. I had some issues getting this project checked out in Eclipse (only D5 tags & branches were showing) so I hope I patched against the right version.

I also dropped the "access arguments" element, as this has already been set to "user_register_access" by the user module (or altered to something else by another module, in which case I guess we should not overwrite it).