when i want to give a height, it does not work. In advanced options i say:
height:150

just like the example says:
Add other jQuery cycle options one per line. Ex. height: 350 Click here for the additional options to add.

Even when i add px or ; at the end it still does not work. When i look at the source it does include the height only it does not work:
"advanced": "height:150"

This doesn't work in the beta2 either

CommentFileSizeAuthor
#8 607424-js_numerics-1.patch3.67 KBredndahead
#4 Screen shot 2010-03-04 at 13.20.35.png13.34 KBhixster
#4 Screen shot 2010-03-04 at 13.20.55.png42.65 KBhixster
#4 Screen shot 2010-03-04 at 13.21.10.jpg127.21 KBhixster
#4 Screen shot 2010-03-04 at 13.21.16.jpg109.74 KBhixster

Comments

Michsk’s picture

Michsk commented

I got it fixed with css, tough not the way but it works. for those who also need this:

#block-block-2 div{height:150px;overflow:visible;}

as you can see i used it in a block and needed overflow visible.

redndahead’s picture

redndahead commented

Hmm the other option should work so I'll look into that the settings actually get applied.

redndahead’s picture

redndahead commented

You might also need to add containerResize:false

You will have to apply this patch as well to get it to work for now. http://drupal.org/node/632838#comment-2265562

hixster’s picture

hixster commented
Status: Active » Needs work
StatusFileSize
new Screen shot 2010-03-04 at 13.21.16.jpg109.74 KB
new Screen shot 2010-03-04 at 13.21.10.jpg127.21 KB
new Screen shot 2010-03-04 at 13.20.55.png42.65 KB
new Screen shot 2010-03-04 at 13.20.35.png13.34 KB

the patch doesn't work, I still can't get variable height views slideshows. I posted about this here: http://drupal.org/node/194672 , but no response.

I've attached the following:

1) My views_slideshow.js patched code
2) My options in views_slideshow UI ( i've tried false and true, it makes no difference)
3) 2 images that show the container is not resizing.
4) Any help on this appreciated, been trying to get assistance on this for a month now.

redndahead’s picture

redndahead commented
Priority: Normal » Critical

marking as critical to look at before release.

benklocek’s picture

benklocek commented

I'm having trouble with getting the advanced settings to work also.

I've tracked the code down and inserted some console.log statements for firebug. I'm wondering if some of the trouble we are having comes from the data being typed wrong. For example, cleartype = "true" is being sent, not cleartypebg = true, without quotes as sync and random are.

I reset one of the options I had in advanced from within /views_slideshow/contrib/views_slideshow_singleframe/views_slideshow.js (around line 69) as an integer (instead of as a string as it had been from advanced settings) and it took effect.

I'd submit a patch, but I don't know enough JS to do what is required.

I expect looking at the value from advanced settings and checking type, would make these settings work. The patch from http://drupal.org/node/632838#comment-2265562 is a start, but integers need to be typed, as well as cleaning whitespace.

redndahead’s picture

redndahead commented

For advanced settings there is an eval statement for true and false that types it correctly. Typing int's are something that may need to be done. The advanced settings needs to be reworked.

redndahead’s picture

redndahead commented
Status: Needs work » Needs review
StatusFileSize
new 607424-js_numerics-1.patch3.67 KB

Here is the patch that will be committed. Should fix this issue.

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hixster’s picture

hixster commented

Variable/Fixed height option works great in latest release! Thanks for fixing.

khorpyakov’s picture

khorpyakov commented

Notice that space before number value invalidates numeric parameter. "height:300" is ok and "height: 300" brakes the script normal execution. Maybe trim() function could be useful?

remydenton’s picture

remydenton commented
Priority: Critical » Normal
Status: Closed (fixed) » Needs work

I'm re-opening this issue because, as khorpyakov pointed out, adding a space breaks this functionality. It's not a huge deal once you've figured it out, but the problem is that the example given right below the field has a space in it: "Ex. height: 350". I think at the very least the example needs to be changed.

ejohnson’s picture

ejohnson commented

Can one use a Percentage value (ie. 100%) for the Advanced Options instead of it being a fixed value?

On the ContainerResize, added 0 to strip the style width and height causes the slideshow to disappear completely. How would one add width and height 100% or an alternative to fix this?

The height and width options for the Advanced Options, what does this affect/change in the code (ie. is this changing the image height/width or some container)?

None of these changes seem to be taking affect for me in the code.

Thanks for any input.

EDIT: I see this is a Drupal 6 thread. I'm referring to Drupal 7.

redndahead’s picture

redndahead commented
Status: Needs work » Closed (fixed)

Please open a new issue. This thread was for 2.x and applied to that.