Optionally delete feed items with feed nodes

in feeds.module, feeds_nodeapi(), add a call to clear() before deleting source

case 'delete':
        // Remove feed from scheduler and delete source.
        feeds_scheduler()->remove($importer_id, 'import', $node->nid);
        feeds_source($importer_id, $node->nid)->clear();
        feeds_source($importer_id, $node->nid)->delete();
        break;

doesn't this accomplish what you want? The challenges you list above I don't quite understand them, are they no longer a problem with the newer feeds version?

this does however force deleting of all items without giving the user and option. This behavior may not be desired (although I can't imagine when), but it is really useful when building and testing feeds.

Subscribing

Any update on this? Deleting a feed often means we no longer wants news from it, so there must be an option to proceed with items deletion when deleting the feed.

+1
Subscribing.

Has this been fixed? I'm still encountering the feed items being imported, although the feed has been deleted for some time. Is there a solution to fix this?

I'd love to see this implemented in some form - I'm spending a lot of time writing custom queries to clean up "zombie" feed items that get left behind when users delete parent feed nodes without deleting all of the child feed items first.

The way I envision it, feed items should always be deleted when the parent feed node is deleted. If someone just wants to stop importing new items, there should be an option to disable the feed without deleting it. But a feed item should never exist without a parent feed- that's like a comment existing without a parent node.

Just my humble opinion.

I like Dane #7 idea that all feed items should ALWAYS have a feed node parent. Makes the logic easier to implement so that deleting a feed node deletes all its items.

Needed this myself. The wording could probably use some work on the form item. I currently have the option disabled when the importer isn't bound to a node, but it's trivial to hide it as well.

Here's my latest patch from #954814: Automatically delete feed items when feed node is deleted.. This adds tests.

Check and check.

Hi Twistor,

Is there any reason for your (#13) to disable the delete checkbox in case of a standalone form ?

Thanks

Laurent

@Laurent_, In the case of the standalone form, there is no feed node to delete. The option could be hidden completely, if that's what you mean, but this makes more sense to me. I think though, that you mean for an option that deletes feed items when the importer is deleted, that would be a separate issue.

That patch will need to be re-rolled WRT the latest Git head

Cool, #17 seems to get the job done.

Is there any other solution to do this in Feeds 7.x-2.x ?
Thanks.

Here's a port to 7.x-2.x

We need this in our project and would love to see this rolled out in alpha-5 release.

This needs a test to get in.

I had to apply this patch (from #20) manually, but I must say that it works. I don't know how to make some tests but it works. Thanks.

Here the patch re-rolled for the last release. Still not knowing how to make tests...

EDIT: sorry my comment was the 23th but I've named my patch "...-22"

@anou
If you like to get started with writing tests, here is some documentation about it:
https://www.drupal.org/simpletest
A good start would be following the Simpletest tutorial for Drupal 7. The topics about "Unit testing" and "Selenium testing" can be skipped, as they don't apply for this issue (and most other issues in this queue).

patch #20 doesn't work with the latest dev i.e all child nodes are still present when feed node is deleted.

@nithinkolekar, did you try the patch #23?

patch #20 not worked with both 7.x-2.0-beta1+6-dev, 7.x-2.0-beta1+14-dev

@anou
patch #23 not tested with 7.x-2.0-beta1+6-dev , but after updating to 7.x-2.0-beta1+14-dev (oct 11 released) it works fine.

Nice to read! Then I've still got to jump into making tests... :-)

wait.. :(

something strange with other sites which has xls parser and deletion partially works ie on deletion of feed node only 50 nodes of imported nodes are deleting leaving rest of the node undeleted and also showing only one message "deleted 1 node".

Where as with the csv parser patch works fine and also show two messages "deleted 1 node" and "deleted X nodes" for imported nodes.

I don't know whether nodes are actually deleting because deletion process is finishing fast compare to CSV parser. (Will check database tables for this.)

Just checked by changing xls parser to csv and got the same result : only 50 nodes are deleting. Sorry for my comment #27 where I didn't checked for feed node which had > 50 nodes.