setUp() function accepting array as arguments

Tested on blog modules by changing its argument to an array and it worked fine, bot will test if more common syntax still works.

Good call.

If you really want to change the signature, just make setUp() accept only one $modules arguments.

Anyway, regarding the original issue: calling call_user_func_array(array($this, 'parent::setUp'), $modules) should work.

The reason I didn't switch it...was due to the fact that we are past API changes...so not sure if that will get in since it will require all tests to be changed.

Lets go the full way and do just array.

Committed.

Will need to followup by changing tests.

I'm not sure of the exact meaning of Simpletest contrib 7.x branch as opposed to D7 core, but I'd really support the change. The current setUp($module_1, $module_2, ...) syntax forces convoluted code to build helper classes extending DrupalWebTestCase while allowing subclasses to enable their own custom set of modules.

from field.test:

class FieldTestCase extends DrupalWebTestCase {
function setUp() {
// Call parent::setUp().
$args = func_get_args();
call_user_func_array(array('parent', 'setUp'), $args);

// do stuff...
}
}

Crosslinking to #644628: FieldAttachTestCase cannot be reused

Let's reconsider this for core.

If we do we can use PGP to make a quick script to update all tests.

I will be providing a merge patch between simpletest 2.x and HEAD once I get browser integration complete. Doesn't directly related to this issue, but since it was moved back from 2.x just to keep everyone informed.

This is surprisingly simple and per http://drupal.org/node/644628#comment-2578850 makes a lot of testcases unusable.

Let's get rid of that ugly-assed workaround in FieldTestCase::setUp() while we're at it.

Yay.

#24 does not apply any longer. Also, the EOL whitespace below needs to be removed:

+++ modules/simpletest/drupal_web_test_case.php	2010-02-11 16:06:15 +0000
@@ -1089,7 +1089,9 @@ class DrupalWebTestCase extends DrupalTe
+   *   Either a single array containing a list of modules to enabled or a ¶

Just a reroll, don't ask me to explain this...

Shall we?

Sorry. Couldn't help doing a little cleanup. Minor code change from #27, but still a code change, so back to "needs review".

+++ modules/simpletest/drupal_web_test_case.php	26 Mar 2010 15:06:37 -0000
@@ -1159,10 +1160,12 @@ class DrupalWebTestCase extends DrupalTe
-    // Install modules needed for this test.
-    if ($modules = func_get_args()) {
-      module_enable($modules, TRUE);
+    // Install modules needed for this test. This could have been passed in as
+    // either a single array argument or a variable number of string arguments.
+    if (!is_array($modules)) {
+      $modules = func_get_args();
     }
+    module_enable($modules, TRUE);

This will run module_enable($modules) even if $modules is an empty array ? Not sure this is a big deal though.

Other than that, looks good to me.

Powered by Dreditor.

With #31.

RTBC if green.

Simple reroll - RTBC if green.

I would be nice to add a @todo to remove the legacy stuff in D8.

Seems like a good idea, since that is the plan.

Added the @todo.

This has been hanging around awhile and is holding up other tests. Since the only additional requirements Dries gave in #36 was to add the todo, and this was to-done ;), committed to HEAD.