Menu settings unavailable when user adds a new node and user does not have "administer menu items" permission on default menu

I raised this issue about the integration with the Domain Access module. Is this something the Menu Admin Per Menu guys could advise me on?

I 'fixed' this by commenting out the line

          if ($option_key == $default_value) {
            return;
          }

in function menu_admin_per_menu_form_alter

Will this have any negative consequences that I cannot forsee?

it doesn't really. Aside from the domain integration, I've realised that something is not quite right with this module. I was just helping a user with restricted permissions.

When she edits a previously created node with a menu item it shows the menu item and a filtered list of menus - correct behaviour. But when she creates a node she has no menu settings at all. In fact she cannot create a menu entry herself, and can only edit if it has been created by someone else.

If i comment out the

if ($option_key == $default_value) {
  return;
}

she can see menu settings on node creation as well as node editing. And the menu list is filtered correctly on creation and editing.

So I'm not quite sure what the code is for? The module seems to function as I would expect if it removed and not if it remains.

I understand the purpose of the code, but it seems to remove any menu options when a node has not yet been assigned to a menu - either on creation or edit.

I only have this module affecting menu permissions.

The permissions are:

administer menus - no
administer menu_2 - yes (this is the only menu ticked)

menu_1 is default. if user has access to menu_1 as well then menu settings field shows on node creation.