Download & Extend
nodeorder » Issues

PostgreSQL support

Posted by lportela on October 23, 2009 at 8:07pm
Project:nodeorder
Version:6.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hello.

Currently the module does not work correctly with PostgreSQL. This is because it is not possible to include in the ORDER BY clause, columns that do not appear in the select. This occurs in nodeorder_select_nodes() with weight_in_tid.

I am attaching a patch that fixes this.

Thank you very much.

Leandro

AttachmentSize
nodeorder_6.x-1.x-dev_postgresql.patch771 bytes
Login or register to post comments

Comments

#1

Posted by lportela on October 23, 2009 at 8:07pm
Title:PostgreSQL aupport » PostgreSQL support

#2

Posted by marcp on October 23, 2009 at 10:42pm

@lportela - you make a great point. If you are able to create a patch off DRUPAL-6--1 it would make our job easier to get this in. See http://drupal.org/patch/create for instructions on how to create the patch.

Thanks for bringing this issue to our attention.

#3

Posted by lportela on October 27, 2009 at 2:50pm

According to the request, I send the new version of the patch.

Thanks.

AttachmentSize
nodeorder_6.x-1.x-dev_postgresql_v2.patch 1.54 KB

#4

Posted by tuffnatty on November 13, 2009 at 12:41pm
Status:active» needs review

vote +1 for this patch

#5

Posted by pvanderspek on November 15, 2009 at 1:32pm
Status:needs review» reviewed & tested by the community

I've added the patch to the current dev-version in the 6.x branch. Thanks for the work.

#6

Posted by pvanderspek on November 28, 2009 at 3:40pm
Version:6.x-1.x-dev» 6.x-1.1
Status:reviewed & tested by the community» fixed

#7

Posted by System Message on December 12, 2009 at 3:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.