Download & Extend
Image Exact Sizes » Issues

Thumbnails Not Cropped

Posted by qwerty1234 on May 2, 2006 at 12:28am
Project:Image Exact Sizes
Version:4.7.x-1.x-dev
Component:Miscellaneous
Category:bug report
Priority:critical
Assigned:Unassigned
Status:active

Issue Summary

when you change the thumbnail size in settings for image module, image module automaticaly resizes the thumbs to new setting but images are not croped by this module

Login or register to post comments

Comments

#1

Posted by tayknight on July 11, 2006 at 4:28am

This happens because of the line
if ($node->type == 'image' && $op == 'validate' && variable_get('image_exact_thumbs', 1)) {

When the thumbs are recreated my image.module, no nodeapi $ops are called, so image_exact never gets the chance to work on the thumbs.

#2

Posted by Mirrorball on August 6, 2006 at 8:53pm

This is why this option should be a part of image.module. I submitted a patch yesterday but the developer deleted it. :(

#3

Posted by Darren Oh on August 10, 2006 at 5:03pm

Marked issue 73382 as a duplicate of this issue.

#4

Posted by Darren Oh on August 10, 2006 at 5:05pm
Title:does not work when image module auto resizes thumbnails» Thumbnails Not Cropped

#5

Posted by Zach Harkey on August 15, 2006 at 4:31am
Priority:normal» critical

Marked critical because without this functionality, there's nothing 'exact' about my image sizes, i.e. defeats the whole purpose of the module as I see it.

#6

Posted by piotrdesign on September 7, 2006 at 9:09am

Its a funny thing that when i import images one by one i have image exact make them as squared thumbnails unlike with the mass import. Is there a way to get the mass imported images to change into squared ones as well?

I made a topic here as well:

http://drupal.org/node/82874

I wasnt sure where to post so i did in 2 places

#7

Posted by piotrdesign on September 8, 2006 at 6:59pm
Status:active» closed (fixed)

Here you go guys, lets continue our chat there: http://drupal.org/node/83138

#8

Posted by Darren Oh on September 10, 2006 at 3:38am
Status:closed (fixed)» active

We need to keep this issue open to deal with the failure of this module to crop images.

#9

Posted by DigitalFrontier... on February 28, 2007 at 8:34am
Version:master» 4.7.x-1.x-dev

I noticed two things in my module. First, I had applied a patch which stopped cropping altogether. Erroneous patch from around line 96:

function image_exact_user($op, &$edit, &$user, $category = NULL) {
  if ($op == 'update' && variable_get('image_exact_avatars', 0) && $edit['_account']->picture) {
    list($final_w, $final_h) = explode('x', variable_get('user_picture_dimensions', '190x190'));
    $w = round($final_w / 2);
    $h = round($final_h / 2);
   image_exact_resize( $edit['_account']->picture, $edit['_account']->picture, $w, $h);
  }
}

Should be:

function image_exact_user($op, &$edit, &$user, $category = NULL) {
  if ($op == 'update' && variable_get('image_exact_avatars', 0) && $edit['picture']) {
    list($final_w, $final_h) = explode('x', variable_get('user_picture_dimensions', '190x190'));
    $w = round($final_w / 2);
    $h = round($final_h / 2);
   image_exact_resize( $edit['picture'], $edit['picture'], $w, $h);
  }
}

And the second issue was that if the image had one of its two dimensions smaller than the requested resize dimensions, it would skip cropping altogether and simply resize/stretch the image. I think this comes from an "AND" condition for cropping in the IF statement around line 109:

    if ($source_info['width'] > $final_w && $source_info['height'] > $final_h) {

i.e., what if the width is greater than desired but height is not? It skips the cropping procedures (lines 117 & 124) and continues directly on to the Image Resize function around line 128.

Commenting this IF and it's end bracket has now given me actual exact sizes consistently.