I tried uploading some long, narrow images (fishing lures). I expected the thumbnails to be generated by 1) scaling down the short dimension, and 2) cropping the long dimension.
As you can see in the attached file, what this module actually appears to be doing is 1) scaling the entire image so that the long dimension fits the specified size and then 2) stretching the short dimension to fit the specified size.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | original.png | 24.6 KB | darren oh |
| thumbnail.png | 13.79 KB | darren oh |
Comments
Comment #1
darren ohThe original image.
Comment #2
darren ohI read in the module description, "This module lets you have that by cropping images equally from all sides until the correct aspect ratio is reached, and then scaling." It seems to be skipping the cropping step.
Comment #3
darren ohComment #4
darren ohDuplicate of issue 61338.
Comment #5
piotrdesign commentedSo whats the solution to this problem? because when i mass import the thumbnails dont get corped into squares. What should we do to fix this?
Comment #6
joshk commentedThis is because of a flaw in image module: when importing images it doesn't call all the hooks.
I'm due to revisit this to begin making a 5.0 version shortly, at which point I'll work with the image.modue maintainers to try and address some of these concerns.
However, at this point if you're importing large amounts of images, the module isn't going to do what you want it to do.
Comment #7
piotrdesign commentedCan you guys atleast make a "Rebuild all thumbnails" (like in G2) feature. So that the people who want a square thumbs will be able to convert the existing rectangle ones?
That would be a smart addon as well.
Comment #8
darren ohGood suggestion.
Comment #9
joshk commentedHeh, "you guys" includes you as well. Open source software is not a spectator sport! ;)
This is a good idea though. However, it's a non-trivial thing to develop, and will have to wait until I have time to do.
Comment #10
darren ohI would suggest keeping all our discussion of this issue in one place. This issue is a duplicate of issue 61338. A new feature request should be created to discuss the rebuild-all-thumbnails feature.
Comment #11
piotrdesign commentedHere you go guys, lets continue our chat there: http://drupal.org/node/83138
Comment #12
darren oh