Is there possibility to have a content of each email logged ?
Maybe you know some other modules, which can do it ?
Good module. Thanks.

CommentFileSizeAuthor
#10 mail_logger-add_clear_button-613546.patch2.26 KBWebJohn
#7 mail_logger.module.txt6.57 KBmokko
#4 clear_log.patch2.17 KBmokko

Comments

benone’s picture

benone commented

yuhu! it has it ! :)
I didn't noticed that the Subject field is a link to the content. :)
How can I remove emails from the table ? phpMyAdmin or some better way ?

mokko’s picture

mokko commented
Title: What about email content ? » How to empty mail log?
Version: 6.x-1.0 » 6.x-1.x-dev

Since email content is solved, there remains the other issue: how to empty the log?

I guess there are two ways: empty the log completely or limit the log to some size analog to the watchdog. I am planning to look into this. Any preferences?

benone’s picture

benone commented

Simple empty log button would be enough.
Limit the size of log is a good idea too. But I think it shouldn't be required. Just an option.
Thanks for your reply.

mokko’s picture

mokko commented
Status: Active » Needs review
StatusFileSize
new clear_log.patch2.17 KB

Here. It works with me, but it is really a bit crude. Button doesn't look nice, and it is possible to search for non-existent mail keys after you clear the log.

It's the first time I use drupal's form api.

benone’s picture

benone commented

hey I think I can have a problem with installing this patch, because have no idea how to do it automaticaly under windows.
could you give me quick advise what software I should use to do this?
I really would like to test your works and help you doing with those improvments.

mokko’s picture

mokko commented

I am relatively new to patch myself. Actually, I am writing this on a windows machine, but I use cygwin, which by now I know fairly well. I have no idea how to patch under native windows.

But drupal's handbooks are improving. These days I have used http://drupal.org/patch/apply and it worked nicely. There is also a page for applying patches with windows: http://drupal.org/node/60179 for windows.

I hope this helps

I could also apply the patch and send you the whole file. Hang on, I will upload it later.

mokko’s picture

mokko commented
StatusFileSize
new mail_logger.module.txt6.57 KB

Just replace the existing one with this one. You need to remove the .txt. I had to add it becasue drupal.org doesn't let me upload a .module file.

izmeez’s picture

izmeez commented

subscribing

joachim’s picture

joachim commented
Status: Needs review » Needs work

I think the mail clearing form might be better put on its own tab, rather than at the top of the log viewer.

Also, destructive actions in Drupal should use http://api.drupal.org/api/function/confirm_form/6.

WebJohn’s picture

WebJohn commented
Component: Miscellaneous » Code
Status: Needs work » Needs review
StatusFileSize
new mail_logger-add_clear_button-613546.patch2.26 KB

Based on mokko's work, this patch adds the 'clear log' button in a new tab but does not use a confirm form.

fizk’s picture

fizk commented
Issue summary: View changes
Status: Needs review » Fixed

Committed! I've always wanted this feature :)

  • Commit eb7cd34 on 6.x-1.x by fizk: 
    #613546 mokko, WebJohn: Add clear log button.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.