Recently upgraded to biblio 6.x-1.7. Our data comes exclusively from a single RIS import file. In order to fix some problems with our old data, whe I updated to 1.7 from 1.6 I decided to remove biblio entirely and then install the new version fresh, and then import the RIS database afresh. Things went swimmingly (aside from a time-out on my first attempt to import the RIS file).

However, our default biblio listing view does not seem to be picking up some of the style formatting that it should. In particular, the extra span classes that should surround the fields are not appearing. Our current style is Vancouver, but when I tried changing to Classic or CSE, the output still seems to be missing the class="biblio-authors" span and the class="biblio-title" span. The styles issue is not a bit deal, but I notice in Vancouver style, that our database is putting what looks like an extra blank field as well -- maybe an empty journal abbreviation entry? or something related to the new publication date options? -- Not sure, but the extra period doesn't seem to be showing up when I use other styles.

In the previous version, the classes were not showing up with Vancouver style selected either, but if I changed my output style to Classic or CSE then they would show up there. And it looks like Ron edited the Vancouver style to include them there since I can see them in the code now (thanks Ron! see - Standard classes to use in styles to aid theming?). But none of them seem to displaying in my install regardless of which style I select.

I tried flushing caches, rebuilding templates, and enabling and then once again disabling the biblio-views view in the hopes of returning to a biblio default view. But the issue persists. I still suspect some kind of caching/wrong-version-mixing problem, but can't figure out where that might be coming from.

Here's the site:
http://www.iwh.on.ca/biblio

Any ideas?

Phil.

Comments

rjerome’s picture

This has been fixed in -dev version. The issue resulted from the increased XSS filtering removing the span tags. You could use the -dev version of modify your biblio.module file at line 2217 as shown here... http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/biblio/bibl... (adding 'span' to the list of allowed tags.

Ron.

rjerome’s picture

I forgot to mention that in -dev and subsequent releases, the "biblio-title" span has been renamed to be style specific i.e. "biblio-title-vancoiuver"

Ron.

pkiff’s picture

Thanks once again for your help, Ron. That fixes the styles issue.

And now I can see that my other problem comes from something related to the title(s) field, as the extra period is getting dropped just outside of a second biblio-title span like this:

<span class="biblio-title">
  <span class="biblio-title">
    <a href="/biblio/a-systematic-review-of-occupational-health-and-safety-interventions-with-economic-analyses">A systematic review of occupational health and safety interventions with economic analyses</a>
    .
  </span>
  .
</span>

And that only seems to be happening in Vancouver. I'll see if I can figure this one out myself and report back.

Phil.

rjerome’s picture

Yikes! there shouldn't be two title spans either!! Looking at the code it looks like there may have been a little cut'n'paste mishap.

Ron.

rjerome’s picture

Ok, here's what I think lines 89 - 97 of biblio_style_vancouver.inc should look like...

      if (!empty($node->title))      // title
      {
        if (!empty($authors)) $output .= " ";
        $output .= '<span class="biblio-title-vancouver">';
        $url = biblio_get_title_url_info($node);
        $output .= l($node->title, $url['link'], $url['options']);
        $output .= "</span>";
        if (!preg_match("/[?!.]$/", $node->title)) $output .= ".";
      }
pkiff’s picture

I'd almost fixed that myself, but your code looks cleaner than mine. That fixes it:
http://www.iwh.on.ca/biblio

Thanks.

Our scientists love biblio, and we've only started to scratch the surface of what you can do with it.

Phil.

rjerome’s picture

Status: Active » Fixed

Great, we'll call this fixed then.

Ron.

(http://drupal.org/cvs?commit=280162)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.