Using Organic Groups with i18n module Cannot redeclare i18n_get_lang

Hi,

I have the same problem (Drupal 4.7 og&i18n as of 15.5.06) - is there a provisorical way to get those two work alongside? For the time being I could do without the language-choice-function in og.

Best
.r.

someone needs to writeup the desired behavior when both these modules are enabled.

the short answer for most folks with this question is : rename the og version of this function to something unused (i renamed it to og_i18n_get_lang).

i think the longer answer is for i18n to provide a hook for other modules to modify it's way of choosing its language.

currently, the i18n_get_lang logic looks like this:

  $languages = i18n_supported_languages();

  if ($i18n_langpath && array_key_exists($i18n_langpath,$languages)) {
    $i18n_lang = $i18n_langpath;
  }
  elseif ($user->uid && $user->language && array_key_exists($user->language,$languages)) {
    $i18n_lang = $user->language;
  }
  elseif (variable_get("i18n_browser",0) && $lang=i18n_get_browser_lang()) {
    $i18n_lang=$lang;
  }
  else {
    $i18n_lang=key($languages);
  }

  return $i18n_lang;

In other words, the language is decided, in priority order, from:

1. the language prefix for the path
2. the users' language
3. browser language detection (if enabled)
with a fall back to drupal's default language.

A general way to interact with this would be for i18n to instead convert the above logic into an associative array '$get_languages' with keys:

path =>
user =>
browser =>
default =>

and then pass it to the module hooks which could interject or reorder it,
and then i18n would just use reset($get_languages) to shift the first value off the top.

In this model, organic groups would just interject the current group's default language after the user value.

If this seems sensible, i can write up some code.

Well, that may work but the thing is that if you are not using og + i18n, that hook will never be called.

So I think we need something like a conditional definition + specific function call

What I'm trying to understand is why og module needs to set the language that early in the page generation and cannot just overwrite the 'locale' global variable.

Anyway, I've recently started to use og -I really like it :-) and would like both modules besides being 'compatibles' to play together. I mean we could add an og function call in i18n, in the i18n_get_lang logic or maybe expose globally i18n's language so og can also override it.

So I agree with Moshe about writing up the desired behaviour before anything else. If someone's in a hurry to get it working, you can add in og module -which because of the module naming is most likely to load later I think-, a conditional definition -which btw is exactly what I've done so far...

if(!function_exists('i18n_get_lang') {
  function i18n_get_lang() {..}

}

i didn't know about the global $locale variable. that looks good. but if i move this to hook_menu(!$may_cache), then all the static menu items will be in the default language and the rest of the page in the group language. and if i read the code right, andy subsequent uses of phrases that were first shown in the default language will remain in the default language.

So it seems that og does't need to use the i18n function name so thats how we avoid the error for now. any comments?

about to commit a fix. requires the very latest core HEAD or core DRUPAL-4-7 ... the above error goes away because of no longer uses this special function.

Cooool! Thank you so much. Ich will test this weekend.
.r.

I solved this problem by Jose's hint. Thanks!

Change as follwing the module source at modules/localizer/localizer.module about 1278~1280 lines

Previous:
if (module_exists('localizer')) {

Fixed:
if( module_exists('localizer') && !function_exists('i18n_get_lang') ) {

Be careful at "{" and "if ( ... )".

Oops... I thinked shortly.

The duplicated function has very different routine which is located in i18n.module 28line.

function i18n_get_lang($setlanguage = NULL) {
  static $i18n_language;
  //see if the language is already set.
  if ($setlanguage) {
    $i18n_language = $setlanguage;
  } elseif ($i18n_language) {
    return $i18n_language;
  } else {
    _i18n_init();
    return $i18n_language = _i18n_get_lang();
  }
}

Will "Localizer" module occurr some errors when is running with "i18n" module simultaneously?