User picture support
Docc - October 28, 2009 - 09:22
| Project: | Chat Room |
| Version: | 6.x-2.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | justinrandell |
| Status: | fixed |
Description
Patch adds the user picture to the chat user list.
Would be nice to see this feature committed. With a enabled/disabled variable maybe.
| Attachment | Size |
|---|---|
| chatroom_user_picture.patch | 1.13 KB |
#1
#2
thanks for the patch, looking into it.
not sure how the size of the user picture will interact with the width of the chatroom? did you test that?
#3
Totally depends what you set the default picture size to. Looks good at the default 85x85.
Ill extend the patch with custom user picture size for the chatroom (imagecache/Imagecache Profile Pictures?) this week.
#4
great, thanks.
how would integration with imagecache work? would that be an optional dependency?
also, please make any patches against 6.x-2.x-dev, as that's where the action is at right now.
#5
Imagecache will be a optional dep. yes. If not enabled it will default to the default user picture.
#6
sounds good, can't wait to review your patch, i've added a note to HACKING.txt that this feature is being worked on.
#7
still based on HEAD. Because dev is borked and cant get it to work.
Added some profile picture settings to the settings page, including support for imagecache presets.
Didn't looked at the styling yet though.
#8
i've committed a modified version of this patch - thanks!
the styling is rudimentary, and i've left the imagecache stuff untested and not fully integrated.
i'm moving this to 'needs work' until we resolve the styling issues and test with imagecache.
#616304: revamp chat interface is the general issue for making the chat interface better, please feel free to comment there.
also, please patch against 6.x-2.x-dev. its now a lot more stable, so you should be able to use it for testing.
#9
getting back to this, more code committed to make it more robust.
#10
Docc: please test this now, i've cleaned up, squashed bugs etc, so this is ready for some testing.
use the latest cvs on 6.x-2 branch and let me know what's broken.
#11
looks good, seems to be stable now.
Though why not leaving user picture support global?
Also a small bug, there should be a better check if user picture is enabled or not.
Small patch attached
#12
thanks, committed here - http://drupal.org/cvs?commit=287556
please reopen if you find any other issues.
#13
Hi,
Just to say the feature worked a bit before, but I can't seem to enable the user pictures.
Everytime I save the chat node, the User picture option is unchecked.
Am I missing something ?
#14
artscoop, no error messages?
User profile has been moved from a system variable to its own column somewhere down the line.
You should uninstall the module and then reinstall for the new schema to take affect.
(uninstalling means losing your chatsettings)
#15
artscoop - please reopen this if its not fixed by Docc's suggestion.