Patch adds the user picture to the chat user list.
Would be nice to see this feature committed. With a enabled/disabled variable maybe.

CommentFileSizeAuthor
#11 chatroom_user_picture_check.patch5.13 KBDocc
#7 chatroom_user_picture2.patch3.73 KBDocc
chatroom_user_picture.patch1.13 KBDocc

Comments

Docc’s picture

Docc commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »

thanks for the patch, looking into it.

not sure how the size of the user picture will interact with the width of the chatroom? did you test that?

Docc’s picture

Docc commented

Totally depends what you set the default picture size to. Looks good at the default 85x85.
Ill extend the patch with custom user picture size for the chatroom (imagecache/Imagecache Profile Pictures?) this week.

Anonymous’s picture

Anonymous (not verified) commented
Version: master » 6.x-2.x-dev

great, thanks.

how would integration with imagecache work? would that be an optional dependency?

also, please make any patches against 6.x-2.x-dev, as that's where the action is at right now.

Docc’s picture

Docc commented

Imagecache will be a optional dep. yes. If not enabled it will default to the default user picture.

Anonymous’s picture

Anonymous (not verified) commented

sounds good, can't wait to review your patch, i've added a note to HACKING.txt that this feature is being worked on.

Docc’s picture

Docc commented
StatusFileSize
new chatroom_user_picture2.patch3.73 KB

still based on HEAD. Because dev is borked and cant get it to work.
Added some profile picture settings to the settings page, including support for imagecache presets.

Didn't looked at the styling yet though.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

i've committed a modified version of this patch - thanks!

the styling is rudimentary, and i've left the imagecache stuff untested and not fully integrated.

i'm moving this to 'needs work' until we resolve the styling issues and test with imagecache.

#616304: revamp chat interface is the general issue for making the chat interface better, please feel free to comment there.

also, please patch against 6.x-2.x-dev. its now a lot more stable, so you should be able to use it for testing.

Anonymous’s picture

Anonymous (not verified) commented

getting back to this, more code committed to make it more robust.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Docc: please test this now, i've cleaned up, squashed bugs etc, so this is ready for some testing.

use the latest cvs on 6.x-2 branch and let me know what's broken.

Docc’s picture

Docc commented
StatusFileSize
new chatroom_user_picture_check.patch5.13 KB

looks good, seems to be stable now.
Though why not leaving user picture support global?

Also a small bug, there should be a better check if user picture is enabled or not.

Small patch attached

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

thanks, committed here - http://drupal.org/cvs?commit=287556

please reopen if you find any other issues.

artscoop’s picture

artscoop commented
Status: Fixed » Active

Hi,
Just to say the feature worked a bit before, but I can't seem to enable the user pictures.
Everytime I save the chat node, the User picture option is unchecked.
Am I missing something ?

Docc’s picture

Docc commented

artscoop, no error messages?

User profile has been moved from a system variable to its own column somewhere down the line.
You should uninstall the module and then reinstall for the new schema to take affect.

(uninstalling means losing your chatsettings)

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

artscoop - please reopen this if its not fixed by Docc's suggestion.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.