setting up Custom Pagers to allow browsing next/previous image in gallery

Sorry, but:

http://drupal.org/node/318

and

change function theme_image_body:

Why? What's happended to Drupal's theme functionality?

+1 This works OK. I would use &laquo and %raquo instead of the double > or < and only use one pipe in between, but other than that, it is a basic and necessary function.

-1 Code needs work.

Is this a feature that can be implemented? I'd really like to see this functionality in this module. I see a few different work arounds but all of them are confusing and do not work properly.

thx for the hack... but there is a mysql error if u dont select any term.

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND n.nid=t.nid ORDER BY n.title ASC' at line 1 query: SELECT n.nid FROM term_node t, node n WHERE t.tid= AND n.nid=t.nid ORDER BY n.title ASC in ...\includes\database.mysql.inc on line 120.

Yes. This SQL error is easily fixed by adding an if ($terms) around the terms SQL search:

function ph_image_navigation(&$node) {
  global $base_url;
  $previous=0;
  $next=0;
  $tmp_prev=-1;
  $output="<br>";
  $terms = taxonomy_node_get_terms_by_vocabulary($node->nid, _image_gallery_get_vid());
  if ($terms) {
    $term = array_pop($terms);
    $res = db_query("SELECT n.nid FROM {term_node} t, {node} n WHERE t.tid=$term->tid AND n.nid=t.nid ORDER BY n.title ASC");
    for($i=0;$i<db_num_rows($res);$i++) {
      $nidvalue=db_result($res,$i);
      if($previous!=0 && $next==0) {
        $next=$nidvalue;
      }
      if($nidvalue == intval($node->nid)) {
        $previous=$tmp_prev;
      }
      $tmp_prev=$nidvalue;
    }
    $output .= '<div class="links">';
    if($previous>0) { $output .= "<a href=\"$base_url/node/$previous#pict\"><< previous photo <<</a>  "; }
    else $output .= "<< previous photo <<  ";
    $output .= " || ";
    if($next>0) { $output .= "<a href=\"$base_url/node/$next#pict\">>> next photo >></a>"; }
    else $output .= ">> next photo >>";
    $output .= '</div><a name=pict></a><br>';
    return $output;
  }
}

Okay this probably isn't the best place to post this but I mocked up a way to add this bit of HTML into a block as well as the body.

function image_block($op, $delta = 0) {
  switch ($op) {
    case 'list':
      $block[0]['info'] = t('Latest image');
      $block[1]['info'] = t('Random image');
      $block[2]['info'] = t('Image Nav');

      return $block;
    case 'view':
      if (user_access('access content')) {
        switch($delta) {
          case 0:
            $images = image_get_latest();
            $block['subject'] = t('Latest image');
            $block['content'] = l(image_display($images[0], 'thumbnail'), 'node/'.$images[0]->nid, array(), NULL, NULL, FALSE, TRUE);
            break;
          case 1:
            $images = image_get_random();
            $block['subject'] = t('Random image');
            $block['content'] = l(image_display($images[0], 'thumbnail'), 'node/'.$images[0]->nid, array(), NULL, NULL, FALSE, TRUE);
            break;
          //CUSTOM BLOCK ADDED TO ENABLE TAX. BASED NAVIGATION
          case 2:
            $node->nid = arg(1);  //COULDN'T FIGURE OUT A BETTER WAY TO GET NODE OBJECT IN HERE---HELP?
            $block['subject'] = t('Image nav');
            $block['content'] = ph_image_navigation($node);
            break;
        }
      }
      return $block;
  }
}

any chance of getting a next/previous hack for the 4.6 module as well? there's a phptemplate solution here, but I'm using xtemplate.

I am posting this against the HEAD.

This really is a BASIC image gallery feature and should be implemented.

if someone wants to roll a patch for this i'll review it. i agree that it would be a useful feature.

marked http://drupal.org/node/134919 as duplicate ...

is it working in 6.x?

subscribe

I do not like to hack the image.module, first because I'm not confident with php, but will be happy if
there is a way to have this done with a template.php code. Any hint?

I used thickbox to get next, prev... is that the type of functionality being suggested? But the next/prev would just appear on the image node itself? What if the image is in more than one gallery?

thought this is related: http://drupal.org/node/193056

Above didnt work in my drupal 6. So I made couple of changes and following scripts works perfectly on my site http://www.ajaypr.com

Below is the updated code you can use to show prev and next in Drupal 6.

1. change function theme_image_body (same as descriibed above by phacka)
function theme_image_body($node, $size) {
return ph_image_navigation($node) . image_display($node, $size) . $node->body;
}

2. Add following php code in image.module

function ph_image_navigation(&$node) {
global $base_url;
$previous=0;
$next=0;
$tmp_prev=-1;
$output="<br>";
$terms = taxonomy_node_get_terms_by_vocabulary($node, _image_gallery_get_vid());
if ($terms) {
$term = array_pop($terms);
$res = db_query("SELECT n.nid FROM {term_node} t, {node} n WHERE t.tid=$term->tid AND n.nid=t.nid ORDER BY n.created DESC");
while ($nidvalue=db_result($res)){
if($previous!=0 && $next==0) {
$next=$nidvalue;
}
if($nidvalue == intval($node->nid)) {
$previous=$tmp_prev;
}
$tmp_prev=$nidvalue;
}
$output .= '<div class="links">';
if($previous>0) { $output .= "<a href=\"$base_url/node/$previous\"><< previous photo <<</a> "; }
else $output .= "<< previous photo << ";
$output .= " || ";
if($next>0) { $output .= "<a href=\"$base_url/node/$next\">>> next photo >></a>"; }
else $output .= ">> next photo >>";
$output .= '</div><a name=pict></a><br>';
return $output;
}
}

did anyone else try this?

I just tried it out on http://www.gochsheim-evangelisch.de/image and it seems to work. The sort order of the images must be set according to the order in the gallery. Mine ist set to "order by file name", so I changed the syntax to ORDER BY n.title ASC - no problems till now.

marked http://drupal.org/node/316773 as duplicate
marked http://drupal.org/node/288543 as duplicate

I've just posted a pager module (choice of 4 pagers via settings) for Image nodes for 5.x-1.x-dev and a patch for Image_gallery at http://drupal.org/node/317902 if anyone has any interest. I'm not on Drupal 6 yet so I have no idea how difficult it would be to adapt. The patch adds Nodeorder support (if used) and the breadcrumb no longer loses the plot if images have multiple taxonomy terms. Works fine here, but it's my first attempt at a module.

That's great, I will give it a try. Thanks very much for your contribution.

I've tried to put this into a patch. It is simply the code from @ajaypr in #16.

Please review so that we can get this moving!

Thanks.

subscribing - I also would really like to see this very basic gallery feature in image_gallery - if possible in a way that the "previous" and "next" links can be translated without changing the code of the module.

yes this is a must have feature, i modified the module, but it would be nice if it is integrated in the module.

i would like to have this too.

Patched with Cygwin @Vista
Tested in Drupal 6.9 with Image alpha 4
Patch seems to work ok, enabling simple previous - next navigation.

Only issue is that it for some reason duplicates images description shown under image. With vanilla alpha 4 there is only on line but with patched there is 2 :P

Whoa. Did you ever read http://drupal.org/coding-standards ? Please live them.

Found reason why it duplicated image descriptions, theres some extra in line 663:

Original:

663   return image_display($node, $size);

Patch:

663   return ph_image_navigation($node) . image_display($node, $size) . $node->body;

Working without duplicate descriptions, just remove extra from there:

663   return ph_image_navigation($node) . image_display($node, $size);

Im still desperately looking a way to add icons next to prev and next links, every modification I do seem to crash image module. Tried to make it look like under image links in "ul" "inline" but didnt get it to work...

Hi, the photos module (www.drupal.org/project/photos) has this functionality already, may be integrating these two?
Greetings,
Martijn

Attached is a patch from the latest version of image.module in CVS

- Indenting a little more like the coding standards define (#27)
- Fix of the double description bug (#28)

I have tested it to the point that it still works, however my image nodes generally don't have descriptions, so @Typo, it would be great if you could test this bit as you found the issue to begin with.

Re the photos project, for myself personally, I am interested in getting this patch through for the image module as that is what I am using on several existing sites.

Sorry - now that I can read the code, I see that the entire approach is rather a dirty hack. This needs to be completely rethought and implemented using Drupal APIs.

Hmm why not use custom pager and views?

@ Magnity (#30)

Your patch seems to work ok, no problems here.

@ sun

Better "dirty" but working hack than no gallery browsing at all...

@Typo, what sun is referring to is that it would be bad practice to commit to the module a hack - not whether it is useful for people to add in themselves if they want to. Imagine the state of the code if all patches were hacks!

@sun, I'm going to have a look at doing it the proper way as I'd really benefit from having this as part of the module. Possibly have a quick chat on IRC if you hang out there?

Yes, I would be open to discuss this in IRC. However, I can tell upfront that I do not have an idea of how this could be done properly. Most probably, image_gallery has to alter the node view of image nodes to add a pager. However, regular pagers in Drupal core assume that the URL of next/previous links keeps the same and only the query string is altered (foo/bar?page=0,1) - contrary to this pager, which would have to link to different node URLs (node/123 ... node/126). I.e., whoever wants to work on this needs a very thorough understanding of Drupal core APIs.

Tried patch - but although it applies I currently cannot see any pager. Perhaps I did not do something required? Is there any other action necessary rather than applying patch (and perhaps clearing cache)?

I still have issues applying this patch:

- Confirmed that image_gallery_image_get_pager_links function is present in image_gallery.module after patch is applied.
- Confirmed that caches are clear, by clicking "clear caches" in Site Config -> Performance, and by reselecting the site theme.

- Confirmed that code is not being output into the html by looking at html source.

I am using D6.9 with all modules up to date. If it is relevant, all of my images are in nested galleries.

Would it be possible please for some of the users who have commented earlier on in the issue to test the patch?

At the moment, it seems to work for justinrandell and sun (i'm assuming that from #38), however i've had issues with it. It would be really good if a few other people could try it.

Thanks,

I applied the patch from #38 to the 6.x-1.0-alpha4 version of image_gallery.module and

• confirmed that image_gallery_image_get_pager_links function is present in image_gallery.module after patch is applied
• confirmed that caches are cleared, by clicking "clear caches" in Site Config -> Performance
• selected a core theme (garland)
• confirmed that code is not being output into the html by looking at html source.

Same questions as Magnity: Is there anything else to do?

Setting this as CNW as @deshilachado and I seem to have both had the same result.

I've also just quickly tried the patch in #37 and it doesn't seem to work either. (although haven't spent time on this one).

Re: #33: Hmm why not use custom pager and views?

Yes!
Ideally, we'd implement galleries as views, the way they were in 5.x-2.x.
You could then use the custom pager module.

@joachim: EclipseGc is already working on a total Image* module revamp, which will probably lead to a new 6.x-2.x branch. It would be great if you join forces with him! :)

Started an issue for this: http://drupal.org/node/405456
Any help gratefully received!

subscribing

Hi I tried it and wrote about it yesterday night, but I don't see my post....
Now just checking if this goes through...
By the way it works well! (just did the code, not the patches)

subscribing...

subscribing... any more progress on this?

Re: #44: as far as I can tell the Image Gallery using Views in 5.x-2.x is still broken.

Really?
Try the dev version.

I risk unending ridicule, but isn't this solved here: http://drupal.org/node/45050 ? It at least worked out fine on a drupal 6.8 site.

Joris

yeah or check out the custom pager module

Or nearly a year ago I posted http://drupal.org/node/317902 - for 5. It works fine, provides several types of next|prev links including thumbnails, supports Nodeorder if used, and the breadcrumb isn't upset by images in multiple taxonomies, but was deemed too specific to get into Image module.

I'm using drupal 6.13 and image module 6.x-1.0-alpha5. Please let me know which code/patch should be applied. There has been so lot of patches and codes in this thread it's confusing.

Galleries now work with Views as of alpha-5.
Something with custom pager module will now be possible.

subscribing...

To get next/previous buttons you can duplicate your image_gallery Gallery page view in Views, give it a unique path and then show one image (as a preview) per page and use views built in pager. It breaks your breadcrumbs but that can be corrected by using str_replace in your theme page.tpl.php file. You also have to play around with the links from your thumbnails to the new page.

Its a bit of work, but I had some good results.

@scubasmurf,

I am hoping that "custom pager" module would now work with image_gallery view. Did you tried that?

@himagarwal,

I didn't try the Custom Pager module. After reading the documentation I was not sure that it would work the way that I wanted and even if it did then it would be just as complex to implement as doing #60.

I have been on a mission to remove custom modules from my site since I finally worked out how to actually use Views.

This is now basically a documentation task: instructions on how to set custom pagers module up to work on image galleries need to be added too our documentation here: http://drupal.org/node/207216

so, are there any good news about this feature?

Not as far as I know, though you can check http://drupal.org/node/207216 for yourself.

To set up a pager on gallery images:

1. install custom pagers and token
2. Create a pager with these settings:
- visibility:
a. If *all* your image nodes are in galleries, just pick 'image' from the node type selection.
b. If some images are not in galleries, enter this PHP code:

if ($node->type == 'image') {
  $vid = variable_get('image_gallery_nav_vocabulary', '');
  // Check to see if any taxonomy term on this node is a gallery term.
  foreach($node->taxonomy as $term) {
    if ($term->vid == $vid) {
      return TRUE;
    }
  }
}

- pager node list, 'Use a view':
pick 'image_gallery'.
- pager node list, view arguments:
Enter this code (two lines):

term
[term-id]

3. You may need to adjust your vocabulary weights to make sure that the [term-id] token corrrectly produces the gallery term -- the token description says it returns the 'top term' so I presume this considers vocabulary weight. If your images have terms in more than one vocab, move the gallery vocab to be the first.
4. Done. Although your pager will almost certainly need theming: see the custom pagers documentation pages for some snippets (some of which IIRC are mine).

Now forgive me for being a bit grumpy about this, but it's taken me little over half an hour while on a train journey to figure this out and write the above notes. Can it really be the case that *nobody* on who has commented on this issue could spare that much time?

Could someone at least take the above instructions, test-drive them, and then format them nicely and add them to the image module documentation?

Custom pagers module as a whole could do with a bit of love, particularly when it comes to optimisation and theming. Perhaps some of you could pay it forward?

One thing that would be really cool would be code-defined pagers (the same way that modules can define views). If someone were to implement this, we could put the above pager definition into a hook in image_gallery module and save the setup step.

So in order to have next/previous on the image gallery we need to install ANOTHER module?! Isn't there a way to make this work within the Image module, or Views?

Yes -- we reuse other modular components rather than reinventing the wheel.

I'm having a very strange problem setting up the custom pager for images. The pager just does not appear in all images, only in some of them. It even varies within one gallery, so some pictures show the pager (with a lower number of pictures like "1 of 10" even though there are more images in the gallery), and on others the pager does not appear.

I've tried different variants of the pager, with the php snippet or only nody type for visibility, with different settings for pager appearance. The image gallery vocabulary has the lowest weight (it is the first) of all vocabularies, and it also is the only vocabulary that can be applied to images.

The image_gallery view also shows all the images. Tough I'm not using the views-based galleries because I had to hack in support for translating gallery names.

I'm at a loss here, it just seems so totally random.

Update:
I found the problem. It seems to be a really nasty bug in the recommended release (the beta1), that only 10 items are ever displayed. I updated to the dev version and now it seems to work.

Using the dev release is absolutely necessary, the beta1 is broken

We're on beta 4 now; and beta 1 was superseded several months ago.
But glad to hear you've got the pager working eventually :)

The problem is the custom pager module version, not the image module version (of which I use beta3). And the latest release of custom pager is beta1, which seems pretty broken to me. It is also about 1.5 years old, which I only noticed later when looking more closely. It would be less confusing if there would be no recommended release at all.

Thanks for the post explaining how to create the pager.

Joachim, thank you for your hard work; the advice in comment #66 works perfectly for me.

Now, off to work on theming.

Cynthia

Joachim, great job!
thanks a lot!

Image documentation is here: http://drupal.org/handbook/modules/image

...if anyone has a moment to format my above instructions into a new handbook page, so we can finally close this issue.

...done. http://drupal.org/node/709462

Thanks Hetta!

Just for the record: As of version 6.x-1.10-beta1, 'Custom Pagers' have stopped working for me; they vanished completely from all nodes and all sites, be it based on 'image' module or custom bult 'imagefield' nodes. Issue: #688688: Database update from 6.x-1.x-dev to 6.x-1.10-beta1 fails

Greetings, -asb

I followed the guides on installing the custom pager and have it worked on me. But the pager is not limited on the image nodes under the same gallery.

example:
gallery A : 30images
gallery B : 20 images
if i view an image under gallery A, the pager would look something like 1 of 50 images (I am expecting something like 2 of 30)

Hi all,

after having gotten a bit into mighty views.module, I finally succeeded in doing exactly what is requested here. You don't need anything except for views (and, of course, image galleries). It still lacks perfection since the field output rewrite function would benefit from a PHP code option (to properly add base_path(), $language etc), but for me it works after all.

Here's how I did (I use D6.17 and current views 2.x release):

1. Modify the gallery view
   1. Activate the "image gallery" clone view so it will be used instead of original image gallery display.
   2. Select view type "gallery page"
   3. Add a field: Type Global: View result counter
   4. Set the field options to:
      • Rewrite output of the field, value: <a href="/whatever/path_alias/you/like/!2?page=1,[counter]">slide show view</a> (the 1,[counter] syntax is corresponding with the pager element id in the next view, as is the path alias itself)
      • Set "Starting value" to 0
      • Update the field
      • Edit the field "Global: Null" and insert %1 into both the title and breadcrumb text input field, this will display the gallery's name properly (if you like to)
      • Save your view.
2. Create the slide show
2. Add a new view, name it "image gallery slideshow" or whatever
3. Add filter: Node type image
4. Add pager of your desire, either mini or standard, set pager element to 1 instead of 0 (0 did not work for me!)
5. Set pager elements to 1 per page
6. Set Line style to "fields"
7. Add fields suiting your layout requirements
8. Add argument: Taxonomy Term ID, Options as above (title and breadcrumb), Validation: Taxonomy term = "image gallery", argument "Term ID"
9. Optional, if you want to order your images by e.g. their filename:
   • Add relation: Type Image: File, relation is required, image size original
10. Add sort criteria (it should be the same as in the image gallery view above to not break the pager logic)
11. Add View type page
12. Set page property path to whatever/path_alias/you/like/% (see path alias in the view above)
13. save your view

Having done all this will result in:

a) An additional "slide show" link in the gallery view as shown in image 1 (text in german)
b) A slide show view with a pager that always starts with the image corresponding to the clicked link as shown in image 2.

Hope this helps, comments are appreciated!

PS. don't wonder about 2nd image appearing to link to image 6 out of 168, I just cut someting off the screen shot.

@doitDave if you go directly to an image node, you wouldn't see the pager any more right?

Yes, that is right if you mean going there via node/1234. As long as you go there from the gallery, you could probably rewrite all links to lead to the "slideshow item" instead. I did not find it disturbing that both options exist, let's wait what my members will say ;)

Edit: Thinking of it, with rules you could implement a redirect, eg "on viewing a node" -> "if node.type is image then redirect to slideshow item". Whatcha say?

Re-edit: Fail-idea, sorry - further thinking took me back to the root that the node itself just can't know its position in the slideshow ;) But after all, a workaround could be to add a link to the node leading to its gallery and telling the user that a slide show is available there.

The custom pagers method described above gets you a pager on nodes.

Granted, with that you don't get slideshow capabilities.