Using template vsd-upright50 with imagecache selected, imagecache is only used for the slide, not the pager. This is seen by looking at the actual html generated. Putting some debug in template.php, I can see that $vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle'] is set when theme_preprocess_views_slideshow_ddblock(&$vars) is called but not set when theme_preprocess_views_slideshow_ddblock_pager_content(&$vars) is called and it is this setting that is causing the problem further down the line. I've looked through the code and can't see how it could be different for the slide and the pager so I've drawn a blank on what's causing it.

CommentFileSizeAuthor
#16 views_slideshow_ddblock.module.txt17.62 KBjoegraduate
#5 fix-pager-image-cache-1.patch3.26 KBppblaauw
#2 template-imagecache-prob.txt8.62 KBTony Sharpe
#2 debug-output-imgcache-prob.txt1.87 KBTony Sharpe

Comments

ppblaauw’s picture

ppblaauw commented
Status: Active » Postponed (maintainer needs more info)

Did you set an imagecache preset for the pager-item image in the configuration page of the views_block?
Can you attach your template.php file and the result of the debug lines when you enable the debug lines in the configuration page of the views_block.

If possible can you also send a link to the Internet site?

Please send the additional information, so I can help you better.

Tony Sharpe’s picture

Tony Sharpe commented
StatusFileSize
new debug-output-imgcache-prob.txt1.87 KB
new template-imagecache-prob.txt8.62 KB

Yes, imagecache preset was set for both. Site is in test area so can't give a link to it. Attached is the template.php code, including a couple of echo statements printing the value of $vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle']. Attched is the debug printout and down the bottom you'll see the results of the echo statement.
Thanks for your support.

ppblaauw’s picture

ppblaauw commented

I the result of the debug line I see that your pager image cache setting is: 

people_pager

The function backlandjazz_preprocess_views_slideshow_ddblock_pager_content(&$vars) {

does use the 

$vars['views_slideshow_ddblock_pager_settings']

instead of the 

 $vars['views_slideshow_ddblock_slider_settings']

that is why your code

	echo 'Pager' . $vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle'];
	$vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle'] = '1'; /* force as not being set */

has no result

Don't know why image cache preset for the pager image is not used, can not find a bug anymore in the module code.

Did you download the latest dev release from OCT 18?
There was an issue before with image cache (Can't get image_cache working for slide images) which is committed in the version of OCT 18.

Tony Sharpe’s picture

Tony Sharpe commented

Changing my debug echo to echo 'Pager' . $vars['views_slideshow_ddblock_pager_settings']['imgcache_toggle']; This still shows no value as being set.
Without forcing $vars['views_slideshow_ddblock_slider_settings']['imgcache_toggle'] = '1'; then the pager does not use image cache. Note that forcing $vars['views_slideshow_ddblock_pager_settings']['imgcache_toggle'] = '1'; does not solve the problem.
Thanks
Tony

ppblaauw’s picture

ppblaauw commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new fix-pager-image-cache-1.patch3.26 KB

Patch to make image_cache for pager_items work.

Tony Sharpe’s picture

Tony Sharpe commented

Thanks - works fine! Great job.
Tony

ppblaauw’s picture

ppblaauw commented
Title: Imagecache working for slide but not pager » Imagecache working for slide but not pager (fixed)
Version: 6.x-1.x-dev » 6.x-1.0
Status: Needs review » Fixed

Committed to version 6.x-1.0

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Closed (fixed) » Needs work

I am running version 6.x-1-0 of this module and am still seeing this problem.

The patch referenced in comment #5 does not appear to have been applied to to version 6.x-1-0. The issue remained until I manually applied the patch.

Regards,
Joe

Tony Sharpe’s picture

Tony Sharpe commented

Coincidently I have just upgraded to 1.0 and the problem came back. I agree that the patch is not included. I manually patched the file and it's working again.

ppblaauw’s picture

ppblaauw commented

Tony

Could you create a patch file of your changes for version 1.0 and attach it here?

Thanks,

Philip

grimer’s picture

grimer commented

Hi,

I'm having the same problem. Have you had a chance to include the patch?

Thanks,

Rob

grimer’s picture

grimer commented

*Bump*

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented

Phillip,

I think the original patch (the one attached to comment #5) should still fix version 1.0

(At least applying the patch to my 1.0 version seemed to work)

Joe

ppblaauw’s picture

ppblaauw commented
Status: Needs work » Postponed (maintainer needs more info)

#14 joegraduate and Tony Sharpe

Can you attach the views_slideshow_ddblock.module file you patched manually.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
StatusFileSize
new views_slideshow_ddblock.module.txt17.62 KB

Phillip,

The attached file has been manually patched with the patch referenced in comment #5 of this issue/thread as well as the patch referenced in comment #9 of the following issue/thread: http://drupal.org/node/811434#comment-3125942

The issues I had previously experienced (pager ImageCache images not displaying) is not present in my testing with these patches in place.

Thanks for your work on all of this.

Regards,
Joe

ppblaauw’s picture

ppblaauw commented
Status: Postponed (maintainer needs more info) » Fixed

Committed to version 6.x-1.1

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.