Title from settings page doesn't take effect

justin2pin - October 28, 2009 - 19:22
Project:Forward
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I noticed what I believe is a bug where the title specified on the settings page for the "Forward this page" page view isn't actually used in the page callback (actually, the form builder function).

Along with fixing that issue, I pulled calls to drupal_set_title() out of the form builder function and put them in the page callback, added a theme function for theming the page, and renamed "theme_forward_page" to "theme_forward_email".

On submitting this ticket, I also noticed that the version I have isn't even listed above... I'm working from DRUPAL-6--1-9. Perhaps that was part of problem all along. In any case, hope this is helpful.

AttachmentSize
fix-title-issue.patch2.35 KB

#1

stella - October 29, 2009 - 09:56
Project:Frequently Asked Questions» Forward
Version:HEAD» HEAD

Re-assigning to the correct project

#2

seanr - November 3, 2009 - 22:20
Status:needs review» fixed

Fixed. Should be in the next release (later today).

#3

System Message - November 17, 2009 - 22:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.