I'm forced to set "Slide default Music" path. It shouldn't since I'm not using dfgallery module.

In photos/inc/photos.admin.inc, $form['slideshow']['photos_slide_music'] should be changed to:

  // "Slide default Music" will only be required if the dfgallery module is enabled.
  $form['slideshow']['photos_slide_music'] = array(
    '#type' => 'textfield',
    '#default_value' => variable_get('photos_slide_music', false),
    '#title' => t('Slide default Music'),
    '#required' => (module_exists('dfgallery') ? true: false),
    '#description' => t('e.g: http://mysite/music.mp3'),
    '#disabled' => (module_exists('dfgallery') ? false: true)
  );

Comments

genfoch01’s picture

genfoch01 commented

why is it required at all?

xn2001’s picture

xn2001 commented

That is a good question.
I don't know. I'm not currently using dfgallery module.

genfoch01’s picture

genfoch01 commented

I cant get it to work (photo not df gal)... it will let you create an album but when I click on view album all I get is a blank page.
sigh.

xn2001’s picture

xn2001 commented

In photos/inc/photos.admin.inc, $form['slideshow']['photos_slide'] should be changed to:

	$form['slideshow']['photos_slide'] = array(
		'#type' => 'radios',
		'#title' => t('Slide show'),
		'#default_value' => (module_exists('dfgallery') ? 1: 0), //variable_get('photos_slide', 1),
		'#description' => (!module_exists('dfgallery') ? t('Please enable <a href="@url">dfgallery</a> module',array('@url' => url('http://drupal.org/project/dfgallery'))): ''),
		'#options' => array(t('Disabled'), t('Enabled')),
    '#disabled' => (module_exists('dfgallery') ? false: true)
	);

By default, #default_value should be Disabled when dfgallery module is not enabled.

genfoch01’s picture

genfoch01 commented

I have df gal enabled and when I click on slide show it works... but view album just gives a blank page. I'll turn off df gal, make the above code change and let you know the results.

Thank you so much for responding, none of my other posts have been replied to.

genfoch01’s picture

genfoch01 commented

ok, I made the code change above and turned off df gal. as expected the slideshow link no longer works. I just got a blank page. but now I wonder since I am getting a blank page on view album is there some other dependency I am missing? something album photos needs to provide this function?

xn2001’s picture

xn2001 commented

@genfoch01
Please stop hijacking this issue. This is related to the settings of the "Slide show". I wasn't even addressing to you in my previous post(#4).

Now, for your issue, I'm not qualified to answer as I was testing out this module a few days ago. I saw that you created an issue #617446: view album gives blank page about your problem but your description is not specific (Define what is 'view album'. Steps by steps are the best way to go). No 1 will be able to help if you are not specific.

genfoch01’s picture

genfoch01 commented

I was not trying to hijack anything. Since the slide show default music setting appears to be something you must set on photo album I thought they were kind of related. that is issues regarding photo. my apologies.

zenrei’s picture

zenrei commented

I tried the above 2 edits, but I'm still required to enter default music even when I disabled slideshow.

eastcn’s picture

eastcn commented 
      $form['photos']['global']['album']['slide_music'] = array(
        '#type' => 'textfield',
        '#default_value' => !empty($node->album['slide_music']) ? $node->album['slide_music'] : '',
        '#title' => t('Slide Music'),
       // '#required' => TRUE,
        '#description' => t('e.g: http://mysite/music.mp3'),
      );

Please try the latest version of the http://drupal.org/project/photos

nathaniel’s picture

nathaniel commented
Status: Needs review » Closed (fixed)