Posted by pvasili on October 29, 2009 at 9:43am
Jump to:
| Project: | Simplenews |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($item->name) in simplenews/simplenews.admin.inc on line 407. Read more at http://drupal.org/node/322732
Comments
#1
The code is taken from local_user() function. And no, this does not make it code good, but it is as good as its currently gets.