Uploaded original picture files are deleted

Hello,

This module removes all symbols, except alphanumeric characters from the file name. So if you are trying to upload into one gallery two files, for examplea, named file_1.jpg and file$.jpg, module will rename both of them to the file.jpg. And finally you will get one file instead of two.

Of course, I may be wrong and it is something different.

Hello dzhu, hello strengzs,

It is my earnest, I did not expect that this module would find so many sympathizers.

1 - Some bugs exists in the current Version of "Gallery Assist Lightboxes". The points posted here belong to it.

1. The work with the i18n Module eg. Paths go lost by translations.
2. Not reconizing the to including needed lightboxes css- or js- files.
3. Not documentation about: wich supported lightboxes works with the from drupal supported jquery.js (version 1.2.5). Some lightboxes for example prettyPhoto need version 1.3.1 of jquery.js.

I have fixed the above mencioned points. Only the documentation is left.

2 - Can you please write me about your issue with users, permitions etc? waht was your purpose and waht was wrong?

3 - strengzs as you know through dzhu. The upload script rename the original files. It is not correctly but I had my reasons at the beginning. Now I can change it. The posibility to configure your own pattern matching filter for filenames and the option to choose wich save file method to use (FILE_EXISTS_RENAME OR FILE_EXISTS_REPLACE) will be implemented.

4 - http://drupal.org/node/607798 is a "from alone self fixed issue". It is the sample of a premature bug report (:-D) Arran solved self the issue but don't know how.

5 - http://drupal.org/node/618694 - Is a report from dzhu nad is realy a bug. I would call it a missing feature by the File-API. This is a comment only, I have a solution for that.

No hesitate to report issues and feature requests.The firsts are things are to be fixed. The seconds I make if I can and have the time.

I hope I have satisfied your questions and have successfully incorporated a little patience in your impatience.
Don't forget it -You help me to develop THIS_MODULE better.

Thanks and Regards
Juan Carlos

Hello,

I have faced exactly same problem as strengzs reported. The original files are deleted.
Only admin is able to upload files. One odd thing is that it doesn't follow imagecache preset.
I have another preset for fast gallery and it doesn't work for gallery assist.

I think this isn't casued by cron because original files aren't deleted after cron runned. I am not sure how long they are there but they are gone less than a day.

Hello ekkljs, strengzs,

Not all webserver work equal and not all people use the one.

I decide to rename the original files to avoid "path bugs or adress bugs" caused because a user try to upload files called with exotic names or script code.
When a server is correctly customized you have not problems with whitespaces on the hyperlinks.

Equal, I had implemented this feature in the last dev by github.com/jcmc/gallery_assist/downloads. Now you can choose wich method you want. .

Another thing strengzs. if you use imagecache I can't understand why you remove the originals.
Imagecache can't work without them.

I can save storage space on my server with the deletion of originals, but I have to change the preview picture size to get bigger pictures seen in lightbox.

How you want to make this when you remove the originals????

In your case ekkljs, about presets etc. The last action of your preset must be a size action.
When not, how can know Gallery Assist the sizes to build the image, thumbnail boxes and the end the item box.

example
- action 1-> resize 60x60 (have size information)
- action 2-> desaturate (not have size information)

you can think why I not get the first acction?
ok look this example
- action 1-> resize 100x100 (have size information but not you want)
- action 2-> desaturate (not have size information)
- action 3-> crop 70x70 (have size information, the information needed by gallery assist)

I hope it help you
Regards
Juan Carlos

Hello strengzs,

It make me happy that now all works in your installation :-D.

For your information:
ImageCache is very good when you have many requests from your website. ImageCache make your website faster by loading and you have a better flexibility with the customizing of sizes in your layout.

Modules with preset-functionality (posibility to change thumbnail or preview sizes in your layout) needs the originals in case you change the sizes from presets. These modules with this feature, removes the old thumnbnail- or preview- or what ever preset-files and creates new with the new sizes.
In your case you can create new content types with assigments and other presets.

PS:

Anyway, I do not know your concept about the original files:
1, should be there (than we have/had this bug with disappearing of the files)
2, should be deleted

I never delete the originals, or better, the module change only the names (ok I have to update the files table with the new names) .
Extra because of your problem, I have implemented the feature in : Administer -> Site configuration -> Gallery -> Extras
fieldset "Upload process ->Files name filter". If you change this to "none" you have then the originals, which you have always wanted.

I did that with certainty because you are not the only one who has such an installation.

Ok, You and your clients should have fun with Gallery Assist.

Regards
Juan Carlos

I think the thread has become very confusing, but I'm reacting to strengzs first post. He is completely right, the original file will be deleted after a while. I.e. after you run cron.

This happens because gallery assist uses the file_save_upload() function. Quote:

The file will be added to the files table as a temporary file. Temporary files
are periodically cleaned. To make the file permanent file call file_set_status
() to change its status.

So originals are removed I detected to my utter dismay.

Here's the patch that calls file_set_status().

Bumped to 6.x-1.8-beta1, patch and test was against that version.

Hi berenddeboer,

I'm working on a solution of this problems.

I open the issue again.

Regards
Juan Carlos

Thanks Juan. Your module is exactly what is needed in many situations, it's simple, and gets a gallery up immediately, and can be used easily in other pieces of code.

Hi Juan,

I've run into this problem, however I have a slightly different scenario:

I'm using the Gallery Assist 1.6 release code on Drupal 6.x and Linux/Apache (can't remember ver). I'm also using Lightbox 2 and Gallery Assist to Lighbox.

1. If I upload files that are "Portrait" orientation, meaning the image is TALLER than it is WIDE it never gets copied to the root gallery assist folder for that gallery. Therefore, I can never actually DISPLAY the image, only the thumbnails - which DO get created. This is unless I copy the files directly to the file structure using FTP or something AFTER posting them through the UI.

2. If I upload 6 images...then upload 6 more....then upload six more, eventually ALL the images get deleted - this MAY be due to the image file type being set to temporary, but that seems odd to me because I have OLDER galleries (the first 1 or 2 I created) that still work as expected. Only the most recent get deleted.

3. I don't have the administration vs. content creator issues with creating and posting to galleries, I think the person up the thread may not have set the permissions/roles for the gallery_assist content - which is different that core content.

Finally, one request, Bulk Image Uploads? Six at a time with the standard UI sort of sucks. Any thoughts on how to do this in bulk? Like 100 files at a time or something? Thanks!

Regards,
Jim Gross

In this commit is the files.status record by 1.

http://drupal.org/project/cvs/601128

I am not secure or this is the solution for desapearing files. I less this report open and active.

jcmc

Looks good!

I hope it will help, so I will test this solution, when you will release next version with this commit.

Hello dzhu,

wait for the release 6.x-1.8beta2 please. I will make the release today in the next hours.

Regards
Juan Carlos

please give me fedback

Now I use version 6.x-1.8-beta1 patched to change the files.status record to 1. We created two galleries after the patching, and the pictures still haven't disappeared. But I have to reload all previous pictures, because there is no files.status records at all for them. And I prefer to wait a week or so, to see is there any critical bug in 1.8 version, after that upgrade and then reload files. After that I hope I can report about successful module work.

I just want to be sure that 1.8 version is really stable.

hi dzhu,

the 1.8 is the stablest version.

I can you inform wich are the only bugs. The are allready fixed to.

If you use postgresql #298578

if you need the list layout for galleries #297998

I recomended the update.I am workin on the version 2 and all posibilities to import form equal where, mass-uploas and upload compresed files.

Regards
Juan Carlos

I have updated the module, from 6.x-1.8-beta1 to 6.x-1.8, and immediately get two errors, when I have tried to see some galleries:

Fatal error: Cannot redeclare gallery_assist_get_includes() (previously declared in /drupal/modules/gallery_assist/gallery_assist.module:2409) in /drupal/modules/gallery_assist_lightboxes/gallery_assist_lightboxes_display.inc on line 212

Fatal error: Cannot redeclare gallery_assist_image_more_info() (previously declared in /drupal/modules/gallery_assist/gallery_assist.module:2881) in /drupal/modules/gallery_assist_lightboxes/gallery_assist_lightboxes_display.inc on line 378

I have tried to turn off gallery_assist_lightboxes module, it haven't helped. So I have commented both gallery_assist_get_includes() and gallery_assist_image_more_info() functions in the gallery_assist_lightboxes module.

Update

I had 6.x-1.2-beta1 version of Gallery Assist Lightboxes module, now updated to 6.x-1.2, errors haven't appeared again. So it was some incompartibility between Gallery Assist Lightboxes 6.x-1.2-beta1 module and Gallery Assist 6.x-1.8 module.

Hello this issue exist not more at Gallery Assist version 6.x-1.8-beta2 and at Gallery Assist Lightboxes version 6.x-1.2.

It was my error not to advice in the release notes about the change and the Nedd to make the updates simultan to the two modules.

The layout feature "list" was added to the functionalities and the function gallery_assist_get_includes() was moved and centralized from gallery_Assist_lightboxes_display.inc to the mother module.

Today are the last versions:
for GA - 6.x-1.9-beta3
for GA-Lightboxes - 6.x-1.3-beta4

This error is not longer exists.