This is what I thought will be useful for everyone to have..

Now we can push related content either at the beginning of node body or leave it at the end.

Other things what has been changed \ fixed:<ul>
<li>Don't show empty framsets .. !!</li>
<li>Dont call :view in nodeappi if we are not on a single page .. !!</li>
<li><sup>minor</sup> Theming improvements</li>
<li>Various Display Settings improvements</li>
</ul>

Greetz,
T.

p.s. ... this module really ROCKS .. very nice and neat features, simple to use and I'm really really happy to have it with my Drupal 4.7.x .. passionate thank's goes to everyone who has contributed...

CommentFileSizeAuthor
#5 relativity_4.module87.3 KBec
patch_00.txt13.57 KBtomsys

Comments

darius’s picture

Category: support » feature

Hi Toms,

thanks for the improvements, they are really welcome.

The patch will be committed (and tested) much faster if it is split into at least two smaller ones. I would recommend making one patch for cosmetic display and code improvements, etc. (open a new issue) and another -- for the new options of node list placements. The first one can be inspected visually and committed with minimal testing, whereas the second will need more testing.

Thanks,

Darius

darius’s picture

Tomsys,

the patch in http://drupal.org/node/62193 incorporated some of your fixes. To reiterate, we will need separate issues for bugfixes and new functionality.

Darius

ec’s picture

+1 for this great patch I just try against relativity v 1.23. It works fine for me and goes in the right way. But now it fails against the latest v 1.24. Tomsys, it would be great if you could submit again something against 1.24 following Darius recommandations. Keep up the good job guys, regards eric.

darius’s picture

Status: Needs review » Needs work

I would like to propose to make this patch more general. Essentially, users should be able to set an arbitrary order of displaying children, ancestor, etc. fieldsets and node body (a related issue is http://drupal.org/node/32664). The way I see it, we can have a setting with 6-7 drop down lists (so that some fieldsets could be listed twice, for some reason) as follows:
Order Box (fieldset)
1 Children
2 Parents
3 Node body
4 Ancestors
5 ---- (means "none")
6 ----

The fieldset values are selectable from the list (----, node body, ancestors, parents, children). Of course, we should have a sane default order. This approach would be much more flexible.

If someone can think of a better interface of setting the order, please respond! Also, please go ahead and try to code up a patch, if you can. Otherwise, I will probably get to it in a week or two.

I will try to extract the remaining improvements of this patch that are unrelated to the fieldset listing order and apply them.

Darius

ec’s picture

StatusFileSize
new87.3 KB

Dear all,
I took the remaining features given by Tomsys in its patch above and put them in relativity.module v 1.25 (the latest cvs as of today). I also add a "per-node/per-relationship name". This version is a quick hack, the code is commented. Give it a try and let us know. regard, eric.