PostgreSQL compatibility

gatoth - November 4, 2009 - 08:26
Project:Feeds
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs review
Issue tags:Novice
Description

In PostgreSQL queries, strings has to be enclosed in apostrophes ('), quotation marks (") do not work. Please fix it.

Thank you,
Gabor

#1

alex_b - November 4, 2009 - 20:48
Version:6.x-1.0-alpha6» 6.x-1.x-dev

We should do that soon. This is a novice task.

#2

Otaci - November 24, 2009 - 00:01
Status:active» needs review

Patches below replace use of double quote with (escaped) single quote.

AttachmentSize
622932_2_feedsdefaultstest.patch 6.1 KB
622932_2_FeedsFeedNodeProcessor.patch 1.01 KB
622932_2_FeedsImporter.patch 688 bytes
622932_2_FeedsNodeProcessor.patch 2.02 KB
622932_2_FeedsScheduler.patch 1.53 KB
622932_2_FeedsSource.patch 1.13 KB
622932_2_FeedsTermProcessor.patch 784 bytes
622932_2_feedstest.patch 2.91 KB
622932_2_feedstestinc.patch 5.34 KB
622932_2_FeedsUserProcessor.patch 940 bytes

#3

alex_b - November 24, 2009 - 01:59

Great.

2 questions:

1) Wouldn't it be better practice to use double quotes for the query string and single ' quotes for strings in it?
2) One patch instead of 10 ? : )

#4

alex_b - December 21, 2009 - 14:44
Priority:normal» critical

Bumping to critical as this should go into the next alpha release. Any answers for 3.1 ?

 
 

Drupal is a registered trademark of Dries Buytaert.