TAC: D7 port

Marked #820400: Drupal 7 version as duplicate of this issue.

There's no D7 branch at present. I've postponed this issue since I don't have time this summer to work on a D7 port of the module. I'd like to see a D7 version, but I'm not going to be maintaining any D7 sites during the next fiscal year. I don't think keve has plans to work on a port either.

If someone else creates a port I can help with its development this fall, but it's unlikely it will make D7 release.

See also: #871572: Combine forces: merge TAC and TAC_Lite into one package in D7?

@ #17: I haven't started work on this yet, but I'm hoping to do some planning two weeks from now at DrupalCon. I'm still interested in making TAC and TAC_Lite one project, but TAC_Lite opened a partial port to D7 just yesterday.

Some more information for those who are curious. TAC by itself is going to be less than straightforward to port, for three reasons:

1. Database abstraction layer changes: DBTNG has a big impact on TAC, because we use a BIT_OR aggregate that is not exactly your run-of-the-mill SQL. Historically even older postgres has required special support within the module.
2. Taxonomy changes: The taxonomy system has been entirely redone in D7 and there are lots of new hooks.
3. Core access control changes: There are lots of new hooks available and we may want to take advantage of some of these.

@tmuras / anyone else who's interested: If you're going to be at DrupalCon, let me know if you're interested in talking about TAC in D7 or helping port it. (You can use my contact form to email me.)

Here's where I am in the D7 port process. I'll update this as I work through it. Update: the 7.x-1.x branch is now open and a -dev snapshot will be available soon. However, the branch is more or less nonfunctional at this point, so don't get your hopes up just yet. :) Please let me know if you want to help work on one of the tasks below.

1. Run through coder for obvious API changes. Done
2. Get V/U/D ops in hook_node_access_records() working properly for automatically-generated term access data. Done
3. #1097782: Admin forms in D7 Done
4. Research DBTNG API and migrate queries. Done
5. #1097770: Update schema for D7
6. #1097776: Update hook_menu() for D7
7. #1097798: D7: implement create and list ops and provide API
8. #1097804: TAC Fields D7 port
9. #1097806: Provide Views 7.x-3.x filters for each permission
10. #1097816: Update INSTALL.txt, UPDATE.txt, and README.txt

Thanks David! I opened the following issues:

#1097770: Update schema for D7
#1097776: Update hook_menu() for D7
#1097782: Admin forms in D7
#1097798: D7: implement create and list ops and provide API

I'll leave this issue open for now so I can reference it on the project page.

#1097804: TAC Fields D7 port
#1097806: Provide Views 7.x-3.x filters for each permission
#1097816: Update INSTALL.txt, UPDATE.txt, and README.txt

Hmmm. If the port works, that's awesome, but I'm a bit concerned about it being written from scratch. It would be missing seven years of bugfixes, if that makes sense.

In any case, quite interested to see the code, if a working archive can be posted. I've had to put my Drupal development on hold for a few weeks because of other requirements at work, but I will take a look at it whenever I get back to working on the port.

By the way, if anyone else wants to help with the existing port, there is a D7 branch in git and there are several specific issues open (as above).

Re: #41 -- That is because it is not functional yet. :) I unfortunately had to drop work on this due to other circumstances.

Just to let everyone know, the Austrian BIFIE is sponsoring development of the 7.x-dev branch. A functional development version should be available by July 11.

I have added the issue tag d7 release for issues that need to be resolved prior to a D7 release. The next major task is to get the create and list ops working (#1097798: D7: implement create and list ops and provide API). After that, the dev branch should be functional enough for people to begin testing.

Drupal 7 Port Complete

The Drupal 7 port is complete, and the development build is available for testing:
http://drupal.org/node/1089904

Notes and Known Issues:

1. All the module's basic functionality is present. View, Update, Delete, Create, and List grants are functional; and access is updated in response to node and taxonomy changes.
2. The module's internal API has been refactored significantly, improving perfomance, permitting better interoperability, and reducing the risk of future regressions.
3. The create and list grants have been entirely re-designed in the backend, in part because of API changes and in part because of many previous and outstanding bugs in 6.x-1.x and earlier branches:
   • The list grant is stable and should behave as expected.
   • The create grant was actually quite complicated to implement. It appears to be functional, but there are some known bugs and there may be others.
   • The create grant applies to term reference fields on any fieldable entity. In addition to nodes, this includes user profiles and even taxonomy terms themselves.
   • The create grant fully supports core's taxonomy field widgets.
   • Non-core widgets for term reference fields should be functional, but may have usability issues. See #1209158: Support multiselect widget and #1209154: Form UX: disabling vs. hiding disallowed terms for more information. (Note that the Hierarchical Select module's Drupal 7 port has significant bugs by itself and is not recommended.)
   • The create grant currently disabled disallowed terms in form elements rather than removing them entirely. See #1209154: Form UX: disabling vs. hiding disallowed terms for more information.
   • Create grants currently will not be enforced if terms are edited by a different means than a term reference field on a form. See #1209104: Re-add field-level validation in hook_field_attach_validate() for more information.

Recommendations

1. Do not deploy the dev build in production without significant testing.
2. Use the Devel module during testing for accurate feedback on node access behaviors. For more information on using devel, see the module documentation. (There may be minor inconsistencies with Drupal 7 in the instructions.)
3. If you are using a field widget other than those provided by core, Multiselect, or Hierarchical Select, or if you are using some type of taxonomy field other than core's term reference field, test to see if the field behaves as expected when the user does not have create grants. If it doesn't, please open a feature request to support this widget.

What is needed for a 7.x-1.0 release

1. Help test! I do not have any production Drupal 7 sites, so I need as much help testing the module as possible.
2. Issues tagged d7 release need to be resolved before we create a release version.
3. Please, please report any bugs you find!

If the 7.x-1.x-dev build of module works for you, feel free to leave a comment below! However, if you encounter a bug or have a feature request, please do not re-open this issue. Instead, check the open 7.x issues or create a new issue if yours is not yet listed.