Favorite Services JS typo
gbrussel - November 5, 2009 - 16:20
| Project: | Service links |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
There is a typo on line 4 of favorite_services.js that is causing inconsistencies.
if (window.sidebar || window.external.AddFavourite) { should be if (window.sidebar || window.external.AddFavorite) {
Also, I have been testing in Chrome and it is not displaying. The comments in this file say it should only display for FF/IE, any reason why Opera/Chrome/Safari have been neglected?
#1
Correction. That line should read:
if (window.sidebar || window.external) {This now works in IE 7, FF3 and Chrome. Haven't tested Opera/Safari/IE8/IE6.