New permission 'Edit all weblinks'

How would this differ from "edit group weblinks" or "administer weblinks"?

I am having trouble with this too. I want a publisher to be able to edit all weblinks but not have administration rights. I have Access Control module installed and even though I give edit permission to the publisher for the content type of weblinks - it doesn't seem to work. Not sure what to do about this.

I have this problem too. For most content types, it is possible set the authorisation for different roles and select if they can only edit their own content or any content. I would like to authorise a group publishers to edit any weblink (not only their own weblinks), and they should not have the other administation rights.
How can I give them permission to edit any weblink, without giving them permission to create groups or change the settings?

My issue as well. I have about 45 people in charge of maintaining links. The reason for choosing this module was to prevent them from making mistakes that would happen were they just to edit HTML. Given the average technical skill level, I do not want to provide access to Administer Weblinks but would like anyone of them to correct the links created by another.

Encountering a similar situation, I modified the weblinks.module (6.x-2.3) as follows:

Modified the function under the Implementation of hook_weblinks_perm starting at line 58:

function weblinks_weblinks_perm() {
  return array(
    'access web links',
    'create weblinks',
    'edit all weblinks',
    'edit own weblinks',
    'view my weblinks',
    'edit group weblinks',
    'administer weblinks',
    'view click count',
    );
} 

Modified the function under the Implementation of hook_access starting at line 167:

function weblinks_access($op, $node, $account) {
  if ($op == 'create') {
    return user_access('create weblinks', $account);
  }
  
  if ($op == 'update' || $op == 'delete') {
    return user_access('edit all weblinks', $account);
  }

  if ($op == 'update' || $op == 'delete') {
    if (user_access('edit own weblinks', $account) && ($account->uid == $node->uid)) {
      return TRUE;
    }
    if (user_access('administer weblinks', $account)) {
      return TRUE;
    }
  }
}

Note: I gave edit all weblinks both update and delete, if you want users to only be able to update existing links not delete them you would eliminate || $op == 'delete'

I will post a followup if I encounter any issues doing this.

Update: Note NancyDru's post below.

Just a disclaimer: I am not a programmer, just a Lamer, so use at own risk.

The 'edit all weblinks' check is misplaced.

@izmeez @NancyDru I don't have the coding chops to create patches or know what is the correct order for checks. This is just me as a site builder hacking around for solutions to my immediate problems. If "real" coders want to run with it then feel free.

This could be a very useful enhancement, given the comments above. Let us know what you think.
Moving to the 7.x queue as new features will go there first.

Yes, the 'edit all weblinks' is an useful enhancement and I vote for it.

While I haven't touched the Web Links module in D7, my D6 hack worked the way I intended until I retired that site.

It still sounds like there might be a need for greater permission granularity (or at least a level between edit own weblinks and administer weblinks).

I just installed the dev version to take a look at all the good work you've done. I notice that the Node module is creating standard node permissions even for WL. Those should be the ones used and the equivalent custom ones left over from 6.x should be discarded.

Web Links: Create new content
Web Links: Edit own content
Web Links: Edit any content
Web Links: Delete own content
Web Links: Delete any content

Yes, the equivalent ones (Create Weblinks, Edit Own Weblinks) should be removed.

Nancy, Gerhard,
Do you think this should be done before we release 7.x-1.0? We are reducing the number of 7.x blocker issues, which is really good, but I think this one may need to be added, as changing lots of permissions after 1.0 could make much work for admins. What are your thoughts?

Yes, it should be added to avoid unnecessary cleanups.

But it may be better to leave the original issue open for the D6 version and create a new one for D7 dealing with just the permissions cleanup.

Yes, go for it.

I've created a separate issue #2442557: Remove permissions that are now implemented in core node module for 7.x as the changes will be different. Reverting this one to 6.x